[LLDB][NFC] Reliability Fixes for FormatEntity

[fixathon]

Summary

• Remove dead code
• Fix incorrect null-reference check

[fixathon]

lldb/source/Core/FormatEntity.cpp

714–715

This null-check is unreachable and redundant. valobj is already completely null-checked at lines 675 and 705.

1695

Checking var_value_sp for null here is moot; it's already dereferenced in the preceding line. However, exe_scope does require a null-check here, and from the context, it appears that was the original intent thwarted by a typo.

[JDevlieghere]

LGTM

lldb/source/Core/FormatEntity.cpp

if (!valobj->IsSynthetic()) {
         return false;
     }
     break;
 
   default:
     return false;
   }
 
-  if (valobj == nullptr)
-    return false;
-
   ValueObject::ExpressionPathAftermath what_next =
       (do_deref_pointer ? ValueObject::eExpressionPathAftermathDereference
                         : ValueObject::eExpressionPathAftermathNothing);
   ValueObject::GetValueForExpressionPathOptions options;
   options.DontCheckDotVsArrowSyntax()
       .DoAllowBitfieldSyntax()
       .DoAllowFragileIVar()
       .SetSyntheticChildrenTraversal(
if (language_plugin_handled) {
 
               VariableSP var_sp(args.GetVariableAtIndex(arg_idx));
               ValueObjectSP var_value_sp(
                   ValueObjectVariable::Create(exe_scope, var_sp));
               StreamString ss;
               llvm::StringRef var_representation;
               const char *var_name = var_value_sp->GetName().GetCString();
               if (var_value_sp->GetCompilerType().IsValid()) {
-                if (var_value_sp && exe_scope->CalculateTarget())
+                if (exe_scope && exe_scope->CalculateTarget())
                   var_value_sp =
                       var_value_sp->GetQualifiedRepresentationIfAvailable(
                           exe_scope->CalculateTarget()
                               ->TargetProperties::GetPreferDynamicValue(),
                           exe_scope->CalculateTarget()
                               ->TargetProperties::GetEnableSyntheticValue());
                 if (var_value_sp->GetCompilerType().IsAggregateType() &&
                     DataVisualization::ShouldPrintAsOneLiner(*var_value_sp)) {