Page MenuHomePhabricator

[lld/mac] Stop accepting arbitrary suffixes on --(no-)warn-dylib-install-name
ClosedPublic

Authored by thakis on Aug 12 2022, 8:02 AM.

Details

Summary

The flag accidentally used Joined<> instead of Flag<>.

Previously, --warn-dylib-install-namefoobarbaz would be accepted and
had the same effect as -warn-dylib-install-name. Now the flag only
works if no suffix is attached to it, as originally intended.

Also fix a typo in the flag's help text.

Diff Detail

Event Timeline

thakis created this revision.Aug 12 2022, 8:02 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 12 2022, 8:02 AM
thakis requested review of this revision.Aug 12 2022, 8:02 AM

Noticed this while reading Options.td.

Adding a test for this doesn't seem terribly valuable, so I decided against it.

thakis updated this revision to Diff 452185.Aug 12 2022, 8:04 AM
thakis edited the summary of this revision. (Show Details)

fix typo too

MaskRay accepted this revision.Aug 12 2022, 11:31 AM
MaskRay added a subscriber: MaskRay.

LGTM.

This revision is now accepted and ready to land.Aug 12 2022, 11:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2022, 12:27 PM

Whoops, this might've been a copy paste error on my end. Thanks for catching it!