[standalone-build] Build install and use python-lit and run tests for llvm

[kwk]

Summary

This ensures that LLVM sub-projects are being tested with the lit of the same revision.

[kwk]

Locally this errors out with:

lit: /usr/lib/python3.9/site-packages/lit/TestingConfig.py:100: fatal: unable to parse config file '/home/fedora/llvm-zorg/zorg/buildbot/builders/annotated/build/llvm/utils/lit/lit.site.cfg', traceback: Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/lit/TestingConfig.py", line 89, in load_from_path
    exec(compile(data, path, 'exec'), cfg_globals, None)
  File "/home/fedora/llvm-zorg/zorg/buildbot/builders/annotated/build/llvm/utils/lit/lit.site.cfg", line 16, in <module>
    config.llvm_tools_dir = lit_config.substitute("/home/fedora/llvm-zorg/zorg/buildbot/builders/annotated/build/llvm/./bin")
AttributeError: 'LitConfig' object has no attribute 'substitute'

FAILED: CMakeFiles/check-all

[kwk]

• Fix installation of python lit and discoverability of the python lit module

[kwk]

• Fixup python lit installation and run llvm tests
• remove unused defines from lld cmake and move out of directory which later is overwritten by the next git sparse checkout

zorg/buildbot/builders/annotated/standalone-build.sh

build_python_lit() {
     local PYTHON_LIT_BUILD_DIR=$(build_dir python-lit)
     local PYTHON_LIT_INSTALL_DIR=$(install_dir python-lit)
     
     build_step "Sparse checkout out python-lit"
     git -C "${LLVM_ROOT}" sparse-checkout set llvm/utils/lit
 
     build_step "Building python-lit"
     cd "${LLVM_ROOT}"/llvm/utils/lit
-    /usr/bin/python3 setup.py build --build-base ${PYTHON_LIT_BUILD_DIR} '--executable=/usr/bin/python3 -s'
+    python3 setup.py build '--executable=/usr/bin/python3 -s'
+
+    # TODO(kkleine): Fix failing test: FAIL: lit :: shtest-not.py (43 of 50)
+    #build_step "Testing python-lit"
+    #python3 lit.py tests
 
     build_step "Installing python-lit"
     rm -rf ${PYTHON_LIT_INSTALL_DIR}
-    /usr/bin/python3 setup.py install -O1 --skip-build --root ${PYTHON_LIT_INSTALL_DIR}
+    python3 setup.py install -O1 --skip-build --root ${PYTHON_LIT_INSTALL_DIR}
     
     build_step "Removing python-lit build dir"
     rm -rf ${PYTHON_LIT_BUILD_DIR}
+
+    cd -
+}
+
+# We don't install python to the system so we need help python to find it
+discover_python_lit() {
+    build_step "Help discover python-lit module"
+    local PYTHON_LIT_INSTALL_DIR=$(install_dir python-lit)
+    local pyver=$(echo 'import sys; print("{}.{}".format(sys.version_info.major, sys.version_info.minor))' | python3)
+    export PYTHONPATH="${PYTHONPATH:-}:${PYTHON_LIT_INSTALL_DIR}/usr/local/lib/python${pyver}/site-packages"
 }
 
 build_llvm() {
     local PYTHON_LIT_INSTALL_DIR=$(install_dir python-lit)
     local LLVM_BUILD_DIR=$(build_dir llvm)
     local LLVM_INSTALL_DIR=$(install_dir llvm)
 
     build_step "Sparse checkout out llvm"
-    git -C "${LLVM_ROOT}" sparse-checkout set llvm cmake
+    git -C "${LLVM_ROOT}" sparse-checkout set llvm cmake third-party
 
     build_step "Configuring llvm"
 
     cmake \
         -S ${LLVM_ROOT}/llvm \
         -B ${LLVM_BUILD_DIR} \
         -G Ninja \
         -DCMAKE_BUILD_TYPE=${BUILD_TYPE} \
         -DLLVM_BUILD_LLVM_DYLIB=ON \
         -DLLVM_LINK_LLVM_DYLIB=ON \
         -DLLVM_INCLUDE_BENCHMARKS=OFF \
         -DLLVM_INSTALL_UTILS=ON \
-        -DCMAKE_INSTALL_PREFIX=${LLVM_INSTALL_DIR}/bin \
+        -DCMAKE_INSTALL_PREFIX=${LLVM_INSTALL_DIR} \
         -DLLVM_EXTERNAL_LIT=${PYTHON_LIT_INSTALL_DIR}/usr/local/bin/lit \
         -DLLVM_INCLUDE_UTILS:BOOL=ON \
         -DLLVM_INSTALL_UTILS:BOOL=ON \
         -DLLVM_UTILS_INSTALL_DIR:PATH=${LLVM_INSTALL_DIR}/bin
 
     build_step "Building llvm"
     cmake --build ${LLVM_BUILD_DIR}
     
cmake \
         -S ${LLVM_ROOT}/clang \
         -B ${CLANG_BUILD_DIR} \
         -G Ninja \
         -DCMAKE_BUILD_TYPE=${BUILD_TYPE} \
         -DCLANG_LINK_CLANG_DYLIB=ON \
         -DCLANG_INCLUDE_TESTS=ON \
         -DLLVM_EXTERNAL_LIT=${PYTHON_LIT_INSTALL_DIR}/usr/local/bin/lit \
         -DCMAKE_INSTALL_PREFIX=${CLANG_INSTALL_DIR} \
-        -DLLVM_ROOT=${LLVM_INSTALL_DIR}
+        -DLLVM_ROOT=${LLVM_INSTALL_DIR} \
+        -DLLVM_ENABLE_ASSERTIONS=ON \
+        -DLLVM_TABLEGEN_EXE=${LLVM_INSTALL_DIR}/bin/llvm-tblgen
 
     build_step "Building clang"
     LD_LIBRARY_PATH="${LLVM_INSTALL_DIR}/lib64" cmake --build ${CLANG_BUILD_DIR}
 
     build_step "Installing clang"
     rm -rf ${CLANG_INSTALL_DIR}
     cmake --install ${CLANG_BUILD_DIR}
 
build_lld() {
 
     build_step "Configuring lld"
     cmake \
         -S ${LLVM_ROOT}/lld \
         -B ${LLD_BUILD_DIR} \
         -G Ninja \
         -DCMAKE_BUILD_TYPE=${BUILD_TYPE} \
         -DLLVM_LINK_LLVM_DYLIB=ON \
-        -DCLANG_INCLUDE_TESTS=ON \
-        -DLLVM_EXTERNAL_LIT=${PYTHON_LIT_INSTALL_DIR}/usr/local/bin/lit \
         -DCMAKE_INSTALL_PREFIX=${LLD_INSTALL_DIR} \
         -DLLVM_ROOT=${LLVM_INSTALL_DIR}
 
     build_step "Building lld"
     LD_LIBRARY_PATH="${LLVM_INSTALL_DIR}/lib64" cmake --build ${LLD_BUILD_DIR}
 
     build_step "Installing lld"
     rm -rf ${LLD_INSTALL_DIR}
     cmake --install ${LLD_BUILD_DIR}
 
     build_step "Removing lld build dir"
     rm -rf ${LLD_BUILD_DIR}
 }
 
 setup_llvm_project
 pre_build_cleanup
 
 build_python_lit
+discover_python_lit
 build_llvm
 build_clang
 build_lld
 
 exit 0
+