This is an archive of the discontinued LLVM Phabricator instance.

Differential D131695

Compiler.h: remove unused LLVM_NODISCARD
ClosedPublic

Authored by MaskRay on Aug 11 2022, 10:17 AM.

Details

Reviewers
kazu
nikic
Commits
rGc2d293ea25cc: Compiler.h: remove unused LLVM_NODISCARD

Diff Detail

Event Timeline

MaskRay created this revision.Aug 11 2022, 10:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2022, 10:17 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
MaskRay requested review of this revision.Aug 11 2022, 10:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2022, 10:17 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
kazu accepted this revision.Aug 11 2022, 10:29 AM

LGTM. Thank you for migrating LLVM_NODISCARD to [[nodiscard]].

This revision is now accepted and ready to land.Aug 11 2022, 10:29 AM
This revision was landed with ongoing or failed builds.Aug 11 2022, 11:06 AM
Closed by commit rGc2d293ea25cc: Compiler.h: remove unused LLVM_NODISCARD (authored by MaskRay). · Explain Why
This revision was automatically updated to reflect the committed changes.
MaskRay added a commit: rGc2d293ea25cc: Compiler.h: remove unused LLVM_NODISCARD.
Harbormaster completed remote builds in B180710: Diff 451899.Aug 11 2022, 12:48 PM

Revision Contents

PathSize
llvm/
include/
llvm/
Support/
17 lines

Diff 451923

llvm/include/llvm/Support/Compiler.h

Show First 20 Lines • Show All 138 Lines • ▼ Show 20 Lines
#endif #endif
#if defined(__clang__) #if defined(__clang__)
#define LLVM_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX))) #define LLVM_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX)))
#else #else
#define LLVM_DEPRECATED(MSG, FIX) [[deprecated(MSG)]] #define LLVM_DEPRECATED(MSG, FIX) [[deprecated(MSG)]]
#endif #endif
/// LLVM_NODISCARD - Warn if a type or return value is discarded.
// Use the 'nodiscard' attribute in C++17 or newer mode.
#if defined(__cplusplus) && __cplusplus > 201402L && LLVM_HAS_CPP_ATTRIBUTE(nodiscard)
#define LLVM_NODISCARD [[nodiscard]]
#elif LLVM_HAS_CPP_ATTRIBUTE(clang::warn_unused_result)
#define LLVM_NODISCARD [[clang::warn_unused_result]]
// Clang in C++14 mode claims that it has the 'nodiscard' attribute, but also
// warns in the pedantic mode that 'nodiscard' is a C++17 extension (PR33518).
// Use the 'nodiscard' attribute in C++14 mode only with GCC.
// TODO: remove this workaround when PR33518 is resolved.
#elif defined(__GNUC__) && LLVM_HAS_CPP_ATTRIBUTE(nodiscard)
#define LLVM_NODISCARD [[nodiscard]]
#else
#define LLVM_NODISCARD
#endif
// Indicate that a non-static, non-const C++ member function reinitializes // Indicate that a non-static, non-const C++ member function reinitializes
// the entire object to a known state, independent of the previous state of // the entire object to a known state, independent of the previous state of
// the object. // the object.
// //
// The clang-tidy check bugprone-use-after-move recognizes this attribute as a // The clang-tidy check bugprone-use-after-move recognizes this attribute as a
// marker that a moved-from object has left the indeterminate state and can be // marker that a moved-from object has left the indeterminate state and can be
// reused. // reused.
#if LLVM_HAS_CPP_ATTRIBUTE(clang::reinitializes) #if LLVM_HAS_CPP_ATTRIBUTE(clang::reinitializes)
▲ Show 20 Lines • Show All 391 Lines • Show Last 20 Lines