Page MenuHomePhabricator

Don't lower log1p(x) to log(1 + x).
ClosedPublic

Authored by jreiffers on Aug 11 2022, 6:56 AM.

Details

Summary

The latter has accuracy issues around 0. The lowering in MathToLLVM is kept for now.

Diff Detail

Event Timeline

jreiffers created this revision.Aug 11 2022, 6:56 AM
jreiffers requested review of this revision.Aug 11 2022, 6:56 AM
bkramer accepted this revision.Aug 12 2022, 12:38 AM

I don't like it, but it solves a real problem.

This revision is now accepted and ready to land.Aug 12 2022, 12:38 AM
This revision was automatically updated to reflect the committed changes.