This is an archive of the discontinued LLVM Phabricator instance.

Differential D131663

[LLDB][ARM] Extend testing for vpush emulation
ClosedPublic

Authored by DavidSpickett on Aug 11 2022, 2:51 AM.

Details

Reviewers
fixathon
Commits
rG14913fa5d050: [LLDB][ARM] Extend testing for vpush emulation
Summary

https://reviews.llvm.org/D131658 found a bug in
ReadPseudoRegisterValue which would mean we read out
of bounds if the s register number was high enough.

This adds a memory check to vpush-1-thumb, which
should have been doing that anyway. Then copies that
test and uses the last 4 s registers instead.

Without the mentioned fix we see random values in
the final memory, with the fix it passes.

Diff Detail

Event Timeline

DavidSpickett created this revision.Aug 11 2022, 2:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2022, 2:51 AM
Herald added a subscriber: kristof.beyls. · View Herald Transcript
DavidSpickett requested review of this revision.Aug 11 2022, 2:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2022, 2:51 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
DavidSpickett added a reviewer: fixathon.Aug 11 2022, 2:52 AM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptAug 11 2022, 2:52 AM
Harbormaster completed remote builds in B180627: Diff 451788.Aug 11 2022, 2:54 AM
fixathon accepted this revision.Aug 11 2022, 2:54 AM

Thank you for adding this test!

This revision is now accepted and ready to land.Aug 11 2022, 2:54 AM
Closed by commit rG14913fa5d050: [LLDB][ARM] Extend testing for vpush emulation (authored by DavidSpickett). · Explain WhyAug 11 2022, 3:02 AM
This revision was automatically updated to reflect the committed changes.
DavidSpickett added a commit: rG14913fa5d050: [LLDB][ARM] Extend testing for vpush emulation.

Revision Contents

PathSize
lldb/
test/
API/
arm/
emulation/
new-test-files/
test-vpush-1-high-sregs-thumb.dat
test-vpush-1-thumb.dat
32 lines
46 lines

Diff 451788

lldb/test/API/arm/emulation/new-test-files/test-vpush-1-high-sregs-thumb.dat

  • This file was copied from lldb/test/API/arm/emulation/new-test-files/test-vpush-1-thumb.dat.
InstructionEmulationState={ InstructionEmulationState={
assembly_string="vpush {d11, d12, d13, d14}" assembly_string="vpush {s28, s29, s30, s31}"
triple=thumb-apple-ios triple=thumb-apple-ios
opcode=0xed2dbb08 opcode=0xed2dea04
before_state={ before_state={
registers={ registers={
r0=0x00000000 r0=0x00000000
r1=0x00000001 r1=0x00000001
r2=0x00000002 r2=0x00000002
r3=0x00000003 r3=0x00000003
r4=0x00000004 r4=0x00000004
r5=0x00000005 r5=0x00000005
Show All 31 Lines
s20=0x00000000 s20=0x00000000
s21=0x00000000 s21=0x00000000
s22=0x00000000 s22=0x00000000
s23=0x00000000 s23=0x00000000
s24=0x00000000 s24=0x00000000
s25=0x00000000 s25=0x00000000
s26=0x00000000 s26=0x00000000
s27=0x00000000 s27=0x00000000
s28=0x00000000 s28=0x11111111
s29=0x00000000 s29=0x22222222
s30=0x00000000 s30=0x33333333
s31=0x00000000 s31=0x44444444
} }
} }
after_state={ after_state={
memory={
address=0x2fdffe50
data_encoding=uint32_t
data=[
0x11111111
0x22222222
0x33333333
0x44444444
]
}
registers={ registers={
r0=0x00000000 r0=0x00000000
r1=0x00000001 r1=0x00000001
r2=0x00000002 r2=0x00000002
r3=0x00000003 r3=0x00000003
r4=0x00000004 r4=0x00000004
r5=0x00000005 r5=0x00000005
r6=0x00000006 r6=0x00000006
r7=0x2fdffe60 r7=0x2fdffe60
r8=0x00000008 r8=0x00000008
r9=0x00000009 r9=0x00000009
r10=0x0000000a r10=0x0000000a
r11=0x0000000b r11=0x0000000b
r12=0x0000000c r12=0x0000000c
r13=0x2fdffe40 r13=0x2fdffe50
r14=0x00002f80 r14=0x00002f80
r15=0x00002ffc r15=0x00002ffc
cpsr=0x60000030 cpsr=0x60000030
s0=0x00000000 s0=0x00000000
s1=0x00000000 s1=0x00000000
s2=0x00000000 s2=0x00000000
s3=0x00000000 s3=0x00000000
s4=0x00000000 s4=0x00000000
Show All 15 Lines
s20=0x00000000 s20=0x00000000
s21=0x00000000 s21=0x00000000
s22=0x00000000 s22=0x00000000
s23=0x00000000 s23=0x00000000
s24=0x00000000 s24=0x00000000
s25=0x00000000 s25=0x00000000
s26=0x00000000 s26=0x00000000
s27=0x00000000 s27=0x00000000
s28=0x00000000 s28=0x11111111
s29=0x00000000 s29=0x22222222
s30=0x00000000 s30=0x33333333
s31=0x00000000 s31=0x44444444
} }
} }
} }

lldb/test/API/arm/emulation/new-test-files/test-vpush-1-thumb.dat

  • This file was copied to lldb/test/API/arm/emulation/new-test-files/test-vpush-1-high-sregs-thumb.dat.
Show All 37 Lines
s14=0x00000000 s14=0x00000000
s15=0x00000000 s15=0x00000000
s16=0x00000000 s16=0x00000000
s17=0x00000000 s17=0x00000000
s18=0x00000000 s18=0x00000000
s19=0x00000000 s19=0x00000000
s20=0x00000000 s20=0x00000000
s21=0x00000000 s21=0x00000000
s22=0x00000000 s22=0x11111111
s23=0x00000000 s23=0x22222222
s24=0x00000000 s24=0x33333333
s25=0x00000000 s25=0x44444444
s26=0x00000000 s26=0x55555555
s27=0x00000000 s27=0x66666666
s28=0x00000000 s28=0x77777777
s29=0x00000000 s29=0x88888888
s30=0x00000000 s30=0x00000000
s31=0x00000000 s31=0x00000000
} }
} }
after_state={ after_state={
memory={
address=0x2fdffe40
data_encoding=uint32_t
data=[
0x11111111
0x22222222
0x33333333
0x44444444
0x55555555
0x66666666
0x77777777
0x88888888
]
}
registers={ registers={
r0=0x00000000 r0=0x00000000
r1=0x00000001 r1=0x00000001
r2=0x00000002 r2=0x00000002
r3=0x00000003 r3=0x00000003
r4=0x00000004 r4=0x00000004
r5=0x00000005 r5=0x00000005
r6=0x00000006 r6=0x00000006
Show All 24 Lines
s14=0x00000000 s14=0x00000000
s15=0x00000000 s15=0x00000000
s16=0x00000000 s16=0x00000000
s17=0x00000000 s17=0x00000000
s18=0x00000000 s18=0x00000000
s19=0x00000000 s19=0x00000000
s20=0x00000000 s20=0x00000000
s21=0x00000000 s21=0x00000000
s22=0x00000000 s22=0x11111111
s23=0x00000000 s23=0x22222222
s24=0x00000000 s24=0x33333333
s25=0x00000000 s25=0x44444444
s26=0x00000000 s26=0x55555555
s27=0x00000000 s27=0x66666666
s28=0x00000000 s28=0x77777777
s29=0x00000000 s29=0x88888888
s30=0x00000000 s30=0x00000000
s31=0x00000000 s31=0x00000000
} }
} }
} }