This is an archive of the discontinued LLVM Phabricator instance.

[test][NFC] Guard one test case against LLVM checkouts at interesting paths
ClosedPublic

Authored by xen0n on Aug 9 2022, 8:37 PM.

Details

Summary

Previously only the "store" string was being checked for not appearing
twice, but unfortunately the check also looked at the ModuleID and
source_filename lines, so the test case would fail if the LLVM
checkout's absolute path contained the substring "store".

Fix this spurious test failure by tweaking the invocation so the full
path no longer shows up in the output.

Diff Detail

Event Timeline

xen0n created this revision.Aug 9 2022, 8:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2022, 8:37 PM
xen0n requested review of this revision.Aug 9 2022, 8:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2022, 8:37 PM
xen0n updated this revision to Diff 455765.Aug 25 2022, 5:09 PM

Take a different approach where the desired assertion lines are not touched.

xen0n edited the summary of this revision. (Show Details)Sep 22 2022, 12:12 AM
xen0n retitled this revision from [test][NFC] Strengthen an assertion for LLVM checkouts at interesting paths to [test][NFC] Guard one test case against LLVM checkouts at interesting paths.Dec 10 2022, 4:53 PM
lebedev.ri added inline comments.
llvm/test/Transforms/GVNHoist/non-trivial-phi.ll
1

Just change this

xen0n updated this revision to Diff 481895.Dec 10 2022, 9:45 PM

Favor touching nothing besides the lit directive as suggested by @lebedev.ri.

xen0n edited the summary of this revision. (Show Details)Dec 10 2022, 9:45 PM
xen0n marked an inline comment as done.
xen0n added inline comments.
llvm/test/Transforms/GVNHoist/non-trivial-phi.ll
1

This is even less intrusive, thanks! I've updated the diff.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 11 2022, 5:32 AM
This revision was automatically updated to reflect the committed changes.