This is an archive of the discontinued LLVM Phabricator instance.

In D131536#3711617, @MaskRay wrote:

In D131536#3711417, @thanm wrote:

Looks ok. What tests have you run?

I haven't as I don't know how to use the scripts. Sorry :)

These scripts can be just executed w/o args from their dir. At least the Linux scrip runs a small test as well besides building.

dvyukov accepted this revision.Aug 10 2022, 12:05 AM

This revision is now accepted and ready to land.Aug 10 2022, 12:05 AM

% ./buildgo.sh
cc1plus: note: unrecognized command-line option ‘-Wno-unknown-warning-option’ may have been intended to silence earlier diagnostics
==================
WARNING: DATA RACE
Read at 0x00c011110000 by goroutine 2:
  <null>()
      <null>:0 +0x0

Previous write at 0x00c011110000 by main goroutine:
  <null>()
      <null>:0 +0x0
  <null>()
      <null>:0 +0x0

Goroutine 2 (running) created at:
  <null>()
      <null>:0 +0x0
==================
Found 1 data race(s)

Looks good :)

Closed by commit rG0e08061229aa: tsan: update Go rules to use -std=c++17 (authored by MaskRay). · Explain WhyAug 10 2022, 12:32 AM

This revision was automatically updated to reflect the committed changes.

MaskRay added a commit: rG0e08061229aa: tsan: update Go rules to use -std=c++17.

Revision Contents

Path

Size

compiler-rt/

lib/

tsan/

go/

build.bat

2 lines

buildgo.sh

2 lines

Diff 451329

compiler-rt/lib/tsan/go/build.bat

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines	gcc ^
-Wno-attributes ^		-Wno-attributes ^
-Wno-format ^		-Wno-format ^
-Wno-maybe-uninitialized ^		-Wno-maybe-uninitialized ^
-DSANITIZER_DEBUG=0 ^		-DSANITIZER_DEBUG=0 ^
-DSANITIZER_WINDOWS=1 ^		-DSANITIZER_WINDOWS=1 ^
-O3 ^		-O3 ^
-fomit-frame-pointer ^		-fomit-frame-pointer ^
-msse3 ^		-msse3 ^
-std=c++14		-std=c++17

rem "-msse3" used above to ensure continued support of older		rem "-msse3" used above to ensure continued support of older
rem cpus (for now), see https://github.com/golang/go/issues/53743.		rem cpus (for now), see https://github.com/golang/go/issues/53743.

compiler-rt/lib/tsan/go/buildgo.sh

	Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines
	fi			fi

	SRCS="$SRCS $ADD_SRCS"			SRCS="$SRCS $ADD_SRCS"
	for F in $SRCS; do			for F in $SRCS; do
	echo "#line 1 \"$F\""			echo "#line 1 \"$F\""
	cat $F			cat $F
	done > $DIR/gotsan.cpp			done > $DIR/gotsan.cpp

	FLAGS=" -I../rtl -I../.. -I../../sanitizer_common -I../../../include -std=c++14 -Wall -fno-exceptions -fno-rtti -DSANITIZER_GO=1 -DSANITIZER_DEADLOCK_DETECTOR_VERSION=2 $OSCFLAGS $ARCHCFLAGS $EXTRA_CFLAGS"			FLAGS=" -I../rtl -I../.. -I../../sanitizer_common -I../../../include -std=c++17 -Wall -fno-exceptions -fno-rtti -DSANITIZER_GO=1 -DSANITIZER_DEADLOCK_DETECTOR_VERSION=2 $OSCFLAGS $ARCHCFLAGS $EXTRA_CFLAGS"
	DEBUG_FLAGS="$FLAGS -DSANITIZER_DEBUG=1 -g"			DEBUG_FLAGS="$FLAGS -DSANITIZER_DEBUG=1 -g"
	FLAGS="$FLAGS -DSANITIZER_DEBUG=0 -O3 -fomit-frame-pointer"			FLAGS="$FLAGS -DSANITIZER_DEBUG=0 -O3 -fomit-frame-pointer"

	if [ "$DEBUG" = "" ]; then			if [ "$DEBUG" = "" ]; then
	# Do a build test with debug flags.			# Do a build test with debug flags.
	$CC $DIR/gotsan.cpp -c -o $DIR/race_debug_$SUFFIX.syso $DEBUG_FLAGS $CFLAGS			$CC $DIR/gotsan.cpp -c -o $DIR/race_debug_$SUFFIX.syso $DEBUG_FLAGS $CFLAGS
	else			else
	FLAGS="$DEBUG_FLAGS"			FLAGS="$DEBUG_FLAGS"
	Show All 27 Lines

This is an archive of the discontinued LLVM Phabricator instance.

tsan: update Go rules to use -std=c++17ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 451329

compiler-rt/lib/tsan/go/build.bat

compiler-rt/lib/tsan/go/buildgo.sh

tsan: update Go rules to use -std=c++17
ClosedPublic