[libcxx] [test] Split the TEST_HAS_SANITIZERS define into TEST_IS_SLOW

[mstorsjo]

Summary

This makes its role clearer. It's plausible that one may want to manually
define TEST_IS_SLOW when running the tests in some environments - in
particular, it seems to be necessary to use the higher tolerance timeouts
if running the tests on Windows runners on Github Actions.

[mstorsjo]

Add the descriptive comment in one file where it was missing.

[Mordante]

libcxx/test/support/test_macros.h

196

I think the name TEST_IS_SLOW is a bit generic, we have slow tests that don't use this. (*cough* format)
How about TEST_IS_EXECUTED_IN_A_SLOW_ENVIRONMENT or something along these lines?

[mstorsjo]

libcxx/test/support/test_macros.h

196

Right, that makes sense. That macro sure is a mouthful, but it doesn’t need to be super convenient, so it’s probably fine. I can update the patch with that name later tonight.

[mstorsjo]

Switched the name to TEST_IS_EXECUTED_IN_A_SLOW_ENVIRONMENT

libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex.pass.cpp

 typedef std::chrono::milliseconds ms;
 typedef std::chrono::nanoseconds ns;
 
 ms WaitTime = ms(250);
 
 // Thread sanitizer causes more overhead and will sometimes cause this test
 // to fail. To prevent this we give Thread sanitizer more time to complete the
 // test.
-#if !defined(TEST_HAS_SANITIZERS)
+#if !defined(TEST_IS_EXECUTED_IN_A_SLOW_ENVIRONMENT)
 ms Tolerance = ms(50);
 #else
 ms Tolerance = ms(50 * 5);
 #endif
 
 std::shared_timed_mutex m;
 
 void f()

libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/lock.pass.cpp

 typedef std::chrono::milliseconds ms;
 typedef std::chrono::nanoseconds ns;
 
 ms WaitTime = ms(250);
 
 // Thread sanitizer causes more overhead and will sometimes cause this test
 // to fail. To prevent this we give Thread sanitizer more time to complete the
 // test.
-#if !defined(TEST_HAS_SANITIZERS)
+#if !defined(TEST_IS_EXECUTED_IN_A_SLOW_ENVIRONMENT)
 ms Tolerance = ms(25);
 #else
 ms Tolerance = ms(25 * 5);
 #endif
 
 
 void f()
 {

libcxx/test/std/thread/thread.mutex/thread.mutex.requirements/thread.shared_mutex.requirements/thread.shared_mutex.class/lock.pass.cpp

 typedef std::chrono::milliseconds ms;
 typedef std::chrono::nanoseconds ns;
 
 ms WaitTime = ms(250);
 
 // Thread sanitizer causes more overhead and will sometimes cause this test
 // to fail. To prevent this we give Thread sanitizer more time to complete the
 // test.
-#if !defined(TEST_HAS_SANITIZERS)
+#if !defined(TEST_IS_EXECUTED_IN_A_SLOW_ENVIRONMENT)
 ms Tolerance = ms(50);
 #else
 ms Tolerance = ms(50 * 5);
 #endif
 
 void f()
 {
     time_point t0 = Clock::now();

libcxx/test/std/thread/thread.mutex/thread.mutex.requirements/thread.shared_mutex.requirements/thread.shared_mutex.class/lock_shared.pass.cpp

 typedef std::chrono::milliseconds ms;
 typedef std::chrono::nanoseconds ns;
 
 ms WaitTime = ms(250);
 
 // Thread sanitizer causes more overhead and will sometimes cause this test
 // to fail. To prevent this we give Thread sanitizer more time to complete the
 // test.
-#if !defined(TEST_HAS_SANITIZERS)
+#if !defined(TEST_IS_EXECUTED_IN_A_SLOW_ENVIRONMENT)
 ms Tolerance = ms(50);
 #else
 ms Tolerance = ms(50 * 5);
 #endif
 
 void f()
 {
     time_point t0 = Clock::now();

libcxx/test/std/thread/thread.mutex/thread.mutex.requirements/thread.sharedtimedmutex.requirements/thread.sharedtimedmutex.class/try_lock_for.pass.cpp

 typedef std::chrono::nanoseconds ns;
 
 
 ms WaitTime = ms(250);
 
 // Thread sanitizer causes more overhead and will sometimes cause this test
 // to fail. To prevent this we give Thread sanitizer more time to complete the
 // test.
-#if !defined(TEST_HAS_SANITIZERS)
+#if !defined(TEST_IS_EXECUTED_IN_A_SLOW_ENVIRONMENT)
 ms Tolerance = ms(50);
 #else
 ms Tolerance = ms(50 * 5);
 #endif
 
 void f1()
 {
     time_point t0 = Clock::now();

libcxx/test/std/thread/thread.mutex/thread.mutex.requirements/thread.sharedtimedmutex.requirements/thread.sharedtimedmutex.class/try_lock_shared.pass.cpp

 
 typedef std::chrono::system_clock Clock;
 typedef Clock::time_point time_point;
 typedef Clock::duration duration;
 typedef std::chrono::milliseconds ms;
 typedef std::chrono::nanoseconds ns;
 
 
-#if !defined(TEST_HAS_SANITIZERS)
+// Thread sanitizer causes more overhead and will sometimes cause this test
+// to fail. To prevent this we give Thread sanitizer more time to complete the
+// test.
+#if !defined(TEST_IS_EXECUTED_IN_A_SLOW_ENVIRONMENT)
 ms Tolerance = ms(200);
 #else
 ms Tolerance = ms(200 * 5);
 #endif
 
 void f()
 {
     time_point t0 = Clock::now();

libcxx/test/std/thread/thread.mutex/thread.mutex.requirements/thread.sharedtimedmutex.requirements/thread.sharedtimedmutex.class/try_lock_shared_for.pass.cpp

 typedef std::chrono::milliseconds ms;
 typedef std::chrono::nanoseconds ns;
 
 ms WaitTime = ms(250);
 
 // Thread sanitizer causes more overhead and will sometimes cause this test
 // to fail. To prevent this we give Thread sanitizer more time to complete the
 // test.
-#if !defined(TEST_HAS_SANITIZERS)
+#if !defined(TEST_IS_EXECUTED_IN_A_SLOW_ENVIRONMENT)
 ms Tolerance = ms(50);
 #else
 ms Tolerance = ms(50 * 5);
 #endif
 
 void f1()
 {
     time_point t0 = Clock::now();

libcxx/test/std/thread/thread.mutex/thread.mutex.requirements/thread.sharedtimedmutex.requirements/thread.sharedtimedmutex.class/try_lock_until.pass.cpp

 typedef std::chrono::nanoseconds ns;
 
 
 ms WaitTime = ms(250);
 
 // Thread sanitizer causes more overhead and will sometimes cause this test
 // to fail. To prevent this we give Thread sanitizer more time to complete the
 // test.
-#if !defined(TEST_HAS_SANITIZERS)
+#if !defined(TEST_IS_EXECUTED_IN_A_SLOW_ENVIRONMENT)
 ms Tolerance = ms(50);
 #else
 ms Tolerance = ms(50 * 5);
 #endif
 
 void f1()
 {
     time_point t0 = Clock::now();

libcxx/test/support/test_macros.h

 #if !TEST_HAS_FEATURE(cxx_exceptions) && !defined(__cpp_exceptions) \
      && !defined(__EXCEPTIONS)
 #define TEST_HAS_NO_EXCEPTIONS
 #endif
 
 #if TEST_HAS_FEATURE(address_sanitizer) || TEST_HAS_FEATURE(hwaddress_sanitizer) || \
     TEST_HAS_FEATURE(memory_sanitizer) || TEST_HAS_FEATURE(thread_sanitizer)
 #define TEST_HAS_SANITIZERS
+#define TEST_IS_EXECUTED_IN_A_SLOW_ENVIRONMENT
 #endif
 
 #if defined(_LIBCPP_NORETURN)
 #define TEST_NORETURN _LIBCPP_NORETURN
 #else
 #define TEST_NORETURN [[noreturn]]
 #endif