This is an archive of the discontinued LLVM Phabricator instance.

[llvm-profgen] Fix perf script parsing issues
ClosedPublic

Authored by wlei on Aug 8 2022, 3:25 PM.

Details

Summary

Fix two perf script parsing issues:

  1. Redirect the error message to a new file. (the error message mixed in the perfscript could screw up the MMAP event line and cause a parsing failure)
  1. Changed the MMap parsing error message to warning since the perfscript can still be parsed using the preferred address as base address.

Diff Detail

Event Timeline

wlei created this revision.Aug 8 2022, 3:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 3:25 PM
Herald added subscribers: hoy, wenlei. · View Herald Transcript
wlei requested review of this revision.Aug 8 2022, 3:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 3:25 PM
wlei retitled this revision from [llvm-profgen] Fix perf data parsing issues to [llvm-profgen] Fix perf script parsing issues.Aug 8 2022, 3:32 PM
wlei edited the summary of this revision. (Show Details)
wlei added reviewers: hoy, wenlei.
hoy accepted this revision.Aug 8 2022, 3:39 PM
This revision is now accepted and ready to land.Aug 8 2022, 3:39 PM
wenlei accepted this revision.Aug 8 2022, 3:48 PM

lgtm, thanks.

This revision was landed with ongoing or failed builds.Aug 8 2022, 3:52 PM
This revision was automatically updated to reflect the committed changes.