This is an archive of the discontinued LLVM Phabricator instance.

[Matrix] Add tests dot product with varied strides
ClosedPublic

Authored by virnarula on Aug 8 2022, 2:30 PM.

Details

Summary

Add more tests with varied strides. Changes to lowering upcoming in https://reviews.llvm.org/D131125

Diff Detail

Event Timeline

virnarula created this revision.Aug 8 2022, 2:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 2:30 PM
Herald added a subscriber: tschuett. · View Herald Transcript
virnarula requested review of this revision.Aug 8 2022, 2:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 2:31 PM
virnarula edited the summary of this revision. (Show Details)Aug 8 2022, 2:32 PM
virnarula added a reviewer: fhahn.
fhahn added inline comments.Aug 11 2022, 12:59 AM
llvm/test/Transforms/LowerMatrixIntrinsics/dot-product.ll
596

This is the only real strided test now, right? Here it should be sufficient to use a shorter vector, which doesn't generate as much code which makes the check lines easier to read. Also, could you add a comment explaining what's special about this test?

Add comment and change test case size

virnarula marked an inline comment as done.Aug 11 2022, 10:16 AM
fhahn accepted this revision.Aug 11 2022, 10:43 AM

LGTM, thanks!

This revision is now accepted and ready to land.Aug 11 2022, 10:43 AM
This revision was landed with ongoing or failed builds.Aug 11 2022, 11:09 AM
This revision was automatically updated to reflect the committed changes.