[Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

[kazu]

Summary

MapEntryOptionalStorage is an underlying storage class for
OptionalStorage<clang::DirectoryEntryRef>.

This patch deprecates:

OptionalStorage<clang::DirectoryEntryRef>::hasValue
OptionalStorage<clang::DirectoryEntryRef>::getValue

as there is no known users of these two methods.

[dblaikie]

Update this to use something like https://reviews.llvm.org/D131381 ?

[kazu]

In D131368#3707265, @dblaikie wrote:

Update this to use something like https://reviews.llvm.org/D131381 ?

Great idea! Will do!

[kazu]

Updated to use LLVM_DEPRECATED instead of [[deprecated]].

[kazu]

PTAL. Thanks!

[dblaikie]

Sounds good - I'd be probably OK with removing these outright as they're so niche/generally only for use by llvm::Optional anyway - but not much harm in keeping them around for the same period the other more visible APIs are deprecated and cleaning it all up together later/then.

[kazu]

In D131368#3708542, @dblaikie wrote:

Sounds good - I'd be probably OK with removing these outright as they're so niche/generally only for use by llvm::Optional anyway - but not much harm in keeping them around for the same period the other more visible APIs are deprecated and cleaning it all up together later/then.

Yeah, I was actually sitting on the fence, wondering whether I should just remove them now as they are internal details of llvm::Optional as you point out. I think I'll just remove them in three months or so along with other deprecated methods related to llvm::Optional.

clang/include/clang/Basic/DirectoryEntry.h

public:
 
   template <class... ArgTypes>
   explicit MapEntryOptionalStorage(llvm::in_place_t, ArgTypes &&...Args)
       : MaybeRef(std::forward<ArgTypes>(Args)...) {}
 
   void reset() { MaybeRef = optional_none_tag(); }
 
   bool has_value() const { return MaybeRef.hasOptionalValue(); }
-  bool hasValue() const { return MaybeRef.hasOptionalValue(); }
+  LLVM_DEPRECATED("Use has_value instead.", "has_value") bool hasValue() const {
+    return MaybeRef.hasOptionalValue();
+  }
 
   RefTy &value() & {
     assert(has_value());
     return MaybeRef;
   }
-  RefTy &getValue() & {
+  LLVM_DEPRECATED("Use value instead.", "value") RefTy &getValue() & {
     assert(has_value());
     return MaybeRef;
   }
   RefTy const &value() const & {
     assert(has_value());
     return MaybeRef;
   }
+  LLVM_DEPRECATED("Use value instead.", "value")
   RefTy const &getValue() const & {
     assert(has_value());
     return MaybeRef;
   }
   RefTy &&value() && {
     assert(has_value());
     return std::move(MaybeRef);
   }
-  RefTy &&getValue() && {
+  LLVM_DEPRECATED("Use value instead.", "value") RefTy &&getValue() && {
     assert(has_value());
     return std::move(MaybeRef);
   }
 
   template <class... Args> void emplace(Args &&...args) {
     MaybeRef = RefTy(std::forward<Args>(args)...);
   }