[ADT] Deprecate Optional::{hasValue,getValue} (NFC)

[dblaikie]

Looks good, thanks!

llvm/include/llvm/ADT/Optional.h

public:
   void reset() noexcept {
     if (hasVal) {
       val.~T();
       hasVal = false;
     }
   }
 
   constexpr bool has_value() const noexcept { return hasVal; }
-  constexpr bool hasValue() const noexcept { return hasVal; }
+  [[deprecated("Use has_value instead.")]] constexpr bool
+  hasValue() const noexcept {
+    return hasVal;
+  }
 
   T &value() &noexcept {
     assert(hasVal);
     return val;
   }
-  T &getValue() &noexcept {
+  [[deprecated("Use value instead.")]] T &getValue() &noexcept {
     assert(hasVal);
     return val;
   }
   constexpr T const &value() const &noexcept {
     assert(hasVal);
     return val;
   }
-  constexpr T const &getValue() const &noexcept {
+  [[deprecated("Use value instead.")]] constexpr T const &
+  getValue() const &noexcept {
     assert(hasVal);
     return val;
   }
   T &&value() &&noexcept {
     assert(hasVal);
     return std::move(val);
   }
-  T &&getValue() &&noexcept {
+  [[deprecated("Use value instead.")]] T &&getValue() &&noexcept {
     assert(hasVal);
     return std::move(val);
   }
 
   template <class... Args> void emplace(Args &&...args) {
     reset();
     ::new ((void *)std::addressof(val)) T(std::forward<Args>(args)...);
     hasVal = true;
public:
   void reset() noexcept {
     if (hasVal) {
       val.~T();
       hasVal = false;
     }
   }
 
   constexpr bool has_value() const noexcept { return hasVal; }
-  constexpr bool hasValue() const noexcept { return hasVal; }
+  [[deprecated("Use has_value instead.")]] constexpr bool
+  hasValue() const noexcept {
+    return hasVal;
+  }
 
   T &value() &noexcept {
     assert(hasVal);
     return val;
   }
-  T &getValue() &noexcept {
+  [[deprecated("Use value instead.")]] T &getValue() &noexcept {
     assert(hasVal);
     return val;
   }
   constexpr T const &value() const &noexcept {
     assert(hasVal);
     return val;
   }
-  constexpr T const &getValue() const &noexcept {
+  [[deprecated("Use value instead.")]] constexpr T const &
+  getValue() const &noexcept {
     assert(hasVal);
     return val;
   }
   T &&value() &&noexcept {
     assert(hasVal);
     return std::move(val);
   }
-  T &&getValue() &&noexcept {
+  [[deprecated("Use value instead.")]] T &&getValue() &&noexcept {
     assert(hasVal);
     return std::move(val);
   }
 
   template <class... Args> void emplace(Args &&...args) {
     reset();
     ::new ((void *)std::addressof(val)) T(std::forward<Args>(args)...);
     hasVal = true;
public:
   }
   Optional &operator=(const Optional &O) = default;
 
   void reset() { Storage.reset(); }
 
   constexpr const T *getPointer() const { return &Storage.value(); }
   T *getPointer() { return &Storage.value(); }
   constexpr const T &value() const & { return Storage.value(); }
-  constexpr const T &getValue() const & { return Storage.value(); }
+  [[deprecated("Use value instead.")]] constexpr const T &getValue() const & {
+    return Storage.value();
+  }
   T &value() & { return Storage.value(); }
-  T &getValue() & { return Storage.value(); }
+  [[deprecated("Use value instead.")]] T &getValue() & {
+    return Storage.value();
+  }
 
   constexpr explicit operator bool() const { return has_value(); }
   constexpr bool has_value() const { return Storage.has_value(); }
-  constexpr bool hasValue() const { return Storage.has_value(); }
+  [[deprecated("Use has_value instead.")]] constexpr bool hasValue() const {
+    return Storage.has_value();
+  }
   constexpr const T *operator->() const { return getPointer(); }
   T *operator->() { return getPointer(); }
   constexpr const T &operator*() const & { return value(); }
   T &operator*() & { return value(); }
 
   template <typename U> constexpr T value_or(U &&alt) const & {
     return has_value() ? value() : std::forward<U>(alt);
   }
   template <typename U>
   [[deprecated("Use value_or instead.")]] constexpr T
   getValueOr(U &&alt) const & {
     return has_value() ? value() : std::forward<U>(alt);
   }
 
   /// Apply a function to the value if present; otherwise return None.
   template <class Function>
   auto map(const Function &F) const & -> Optional<decltype(F(value()))> {
     if (*this)
       return F(value());
     return None;
   }
 
   T &&value() && { return std::move(Storage.value()); }
-  T &&getValue() && { return std::move(Storage.value()); }
+  [[deprecated("Use value instead.")]] T &&getValue() && {
+    return std::move(Storage.value());
+  }
   T &&operator*() && { return std::move(Storage.value()); }
 
   template <typename U> T value_or(U &&alt) && {
     return has_value() ? std::move(value()) : std::forward<U>(alt);
   }
   template <typename U>
   [[deprecated("Use value_or instead.")]] T getValueOr(U &&alt) && {
     return has_value() ? std::move(value()) : std::forward<U>(alt);