This is an archive of the discontinued LLVM Phabricator instance.

[polly] Fixed a number of typos
ClosedPublic

Authored by GabrielRavier on Aug 4 2022, 7:19 AM.

Details

Summary

I went over the output of the following mess of a command:

(ulimit -m 2000000; ulimit -v 2000000; git ls-files -z | parallel --xargs -0 cat | aspell list --mode=none --ignore-case | grep -E '^[A-Za-z][a-z]*$' | sort | uniq -c | sort -n | grep -vE '.{25}' | aspell pipe -W3 | grep : | cut -d' ' -f2 | less)

and proceeded to spend a few days looking at it to find probable typos
and fixed a few hundred of them in all of the llvm project (note, the
ones I found are not anywhere near all of them, but it seems like a
good start).

Diff Detail

Event Timeline

GabrielRavier created this revision.Aug 4 2022, 7:19 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: arphaman. · View Herald Transcript
GabrielRavier requested review of this revision.Aug 4 2022, 7:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2022, 7:19 AM
inclyc accepted this revision.Aug 6 2022, 1:05 PM
inclyc added a subscriber: inclyc.

LGTM. However I think it is a good idea that we can leave these typos here, and create good first issues for some who doesn't have commit access. And perhaps we also need other reviewers' opinion (those who write these document etc.). You can add reviewers by searching git blame.

This revision is now accepted and ready to land.Aug 6 2022, 1:05 PM

Well, I myself do not have commit access to LLVM, so I suppose this serves as a "good first issue" for me 😅

inclyc added a comment.Aug 6 2022, 9:07 PM

Okay, could you provide your real name and email address? like "My Name <my@email.com>", so that I can commit this for you. Also feel free to ask for commit access.

inclyc added a comment.Aug 6 2022, 9:11 PM

I noticed that your github account seems to be a member of llvm, do you already have the commit access? If so, you can just commit this yourself.

Okay, could you provide your real name and email address? like "My Name <my@email.com>", so that I can commit this for you. Also feel free to ask for commit access.

Gabriel Ravier <gabravier@gmail.com>

I noticed that your github account seems to be a member of llvm, do you already have the commit access? If so, you can just commit this yourself.

I believe the reason my GitHub account is a member of the LLVM organization is that it had to be in order to migrate my comments on the Bugzilla properly

I noticed that your github account seems to be a member of llvm, do you already have the commit access? If so, you can just commit this yourself.

(PS: just to be clear, no I do not have commit access and have tried to push to check if I did (and was unsuccessful))

This revision was automatically updated to reflect the committed changes.