[CMake] [Darwin] Bug 21562 - Add a CMake equivalent for make/platform/clang_darwin.mk in compiler_rt

[beanz]

Summary

First pass at adding cc_kext_* builtin libraries. I need to cleanup and refactor the builtin filtering so that I can use it to filter the builtin symbols list, but this is the first step in the right direction.

[samsonov]

LGTM, but please address comments below.

cmake/Modules/CompilerRTDarwinUtils.cmake

176

Formatting went off here.

185

Remove debug output before submitting.

190

Remove duplicated lines

cmake/Modules/CompilerRTDarwinUtils.cmake

function(darwin_find_excluded_builtins_list os arch min_version)
   
   set(${arch}_${os}_EXCLUDED_BUILTINS
       ${${arch}_${os}_BUILTINS}
       ${${os}_${arch}_BASE_BUILTINS}
       ${${os}_BUILTINS} PARENT_SCOPE)
 endfunction()
 
 # adds a single builtin library for a single OS & ARCH
-function(darwin_add_builtin_library name)
+macro(darwin_add_builtin_library name suffix)
   cmake_parse_arguments(LIB
     ""
     "PARENT_TARGET;OS;ARCH"
-    "SOURCES;CFLAGS"
+    "SOURCES;CFLAGS;DEFS"
     ${ARGN})
-  set(libname "${name}_${LIB_ARCH}_${LIB_OS}")
+  set(libname "${name}.${suffix}_${LIB_ARCH}_${LIB_OS}")
   add_library(${libname} STATIC ${LIB_SOURCES})
   set_target_compile_flags(${libname}
     -isysroot ${DARWIN_${LIB_OS}_SYSROOT}
     ${DARWIN_${LIB_OS}_BUILTIN_MIN_VER_FLAG}
     ${LIB_CFLAGS})
+  set_property(TARGET ${libname} APPEND PROPERTY
+      COMPILE_DEFINITIONS ${LIB_DEFS})
   set_target_properties(${libname} PROPERTIES
       OUTPUT_NAME ${libname}${COMPILER_RT_OS_SUFFIX})
   set_target_properties(${libname} PROPERTIES
     OSX_ARCHITECTURES ${LIB_ARCH})
 
   if(LIB_PARENT_TARGET)
     add_dependencies(${LIB_PARENT_TARGET} ${libname})
   endif()
+
+  list(APPEND ${os}_${suffix}_libs ${libname})
+  list(APPEND ${os}_${suffix}_lipo_flags -arch ${arch} $<TARGET_FILE:${libname}>)
+endmacro()
+
+function(darwin_lipo_libs name)
+  cmake_parse_arguments(LIB
+    ""
+    "PARENT_TARGET"
+    "LIPO_FLAGS;DEPENDS"
+    ${ARGN})
+    add_custom_command(OUTPUT ${COMPILER_RT_LIBRARY_OUTPUT_DIR}/lib${name}.a
+      COMMAND lipo -output
+              ${COMPILER_RT_LIBRARY_OUTPUT_DIR}/lib${name}.a
+              -create ${LIB_LIPO_FLAGS}
+      DEPENDS ${LIB_DEPENDS}
+      )
+    add_custom_target(${name}
+      DEPENDS ${COMPILER_RT_LIBRARY_OUTPUT_DIR}/lib${name}.a)
+    add_dependencies(${LIB_PARENT_TARGET} ${name})
+    message("darwin_lipo_libs: ${COMPILER_RT_LIBRARY_OUTPUT_DIR}/lib${name}.a")
 endfunction()
 
 # Generates builtin libraries for all operating systems specified in ARGN. Each
 # OS library is constructed by lipo-ing together single-architecture libraries.
+# Generates builtin libraries for all operating systems specified in ARGN. Each
+# OS library is constructed by lipo-ing together single-architecture libraries.
 macro(darwin_add_builtin_libraries)
   foreach (os ${ARGN})
     list_union(DARWIN_BUILTIN_ARCHS DARWIN_${os}_ARCHS BUILTIN_SUPPORTED_ARCH)
-    set(${os}_builtin_libs)
-    set(${os}_builtin_lipo_flags)
     foreach (arch ${DARWIN_BUILTIN_ARCHS})
+      # do cc_kext
+      darwin_add_builtin_library(clang_rt cc_kext
+                              OS ${os}
+                              ARCH ${arch}
+                              SOURCES ${${arch}_SOURCES}
+                              CFLAGS "-std=c99" -arch ${arch} -mkernel
+                              DEFS KERNEL_USE
+                              PARENT_TARGET builtins)
+
+
       darwin_find_excluded_builtins_list(${os} ${arch} ${DARWIN_${os}_BUILTIN_MIN_VER})
       # Filter out generic versions of routines that are re-implemented in
       # architecture specific manner.  This prevents multiple definitions of the
       # same symbols, making the symbol selection non-deterministic.
       foreach (_file ${${arch}_SOURCES})
         get_filename_component(_name_we ${_file} NAME_WE)
         list(FIND ${arch}_${os}_EXCLUDED_BUILTINS ${_name_we} _found)
         if(_found GREATER -1)
           list(REMOVE_ITEM ${arch}_SOURCES ${_file})
         elseif(${_file} MATCHES ${arch}/*)
           get_filename_component(_name ${_file} NAME)
           string(REPLACE ".S" ".c" _cname "${_name}")
           list(REMOVE_ITEM ${arch}_SOURCES ${_cname})
         endif ()
       endforeach ()
 
-      darwin_add_builtin_library(clang_rt.builtins
+      darwin_add_builtin_library(clang_rt builtins
                               OS ${os}
                               ARCH ${arch}
                               SOURCES ${${arch}_SOURCES}
                               CFLAGS "-std=c99" -arch ${arch}
                               PARENT_TARGET builtins)
-      list(APPEND ${os}_builtin_libs clang_rt.builtins_${arch}_${os})
-      list(APPEND ${os}_builtin_lipo_flags -arch ${arch} $<TARGET_FILE:clang_rt.builtins_${arch}_${os}>)
     endforeach()
 
-    if(${os}_builtin_libs)
-      add_custom_command(OUTPUT ${COMPILER_RT_LIBRARY_OUTPUT_DIR}/libclang_rt.${os}.a
-        COMMAND lipo -output
-                ${COMPILER_RT_LIBRARY_OUTPUT_DIR}/libclang_rt.${os}.a
-                -create ${${os}_builtin_lipo_flags}
-        DEPENDS ${${os}_builtin_libs}
-        )
-      add_custom_target(clang_rt.${os}
-        DEPENDS ${COMPILER_RT_LIBRARY_OUTPUT_DIR}/libclang_rt.${os}.a)
-      add_dependencies(builtins clang_rt.${os})
-    endif()
+    darwin_lipo_libs(clang_rt.cc_kext_${os}
+                    PARENT_TARGET builtins
+                    LIPO_FLAGS ${${os}_cc_kext_lipo_flags}
+                    DEPENDS ${${os}_cc_kext_libs})
+    darwin_lipo_libs(clang_rt.${os}
+                    PARENT_TARGET builtins
+                    LIPO_FLAGS ${${os}_builtins_lipo_flags}
+                    DEPENDS ${${os}_builtins_libs})
   endforeach()
 endmacro()