This is an archive of the discontinued LLVM Phabricator instance.

Differential D131030

[libunwind] Remove unused substitution in AIX libunwind config
ClosedPublic

Authored by ldionne on Aug 2 2022, 4:21 PM.

Details

Reviewers
MaskRay
Group Reviewers
Restricted Project
Commits
rG44b4f4df31ab: [libunwind] Remove unused substitution in AIX libunwind config
Summary

It must have been a copy-paste error, since cxx-include is never defined
by the libunwind config.

Diff Detail

Event Timeline

ldionne created this revision.Aug 2 2022, 4:21 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 2 2022, 4:21 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ldionne requested review of this revision.Aug 2 2022, 4:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2022, 4:21 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
MaskRay accepted this revision.Aug 2 2022, 8:51 PM
MaskRay added a subscriber: MaskRay.

It must have been a copy-paste error, since cxx-include is never defined by the libunwind config.

IIRC test/configs/cmake-bridge.cfg.in doesn't define %{cxx-include}

This revision is now accepted and ready to land.Aug 2 2022, 8:51 PM
Herald added a subscriber: StephenFan. · View Herald TranscriptAug 2 2022, 8:51 PM
Harbormaster completed remote builds in B178893: Diff 449473.Aug 2 2022, 9:08 PM
Closed by commit rG44b4f4df31ab: [libunwind] Remove unused substitution in AIX libunwind config (authored by ldionne). · Explain WhyAug 3 2022, 6:28 AM
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rG44b4f4df31ab: [libunwind] Remove unused substitution in AIX libunwind config.

Revision Contents

PathSize
libunwind/
test/
configs/
2 lines

Diff 449651

libunwind/test/configs/ibm-libunwind-shared.cfg.in

# Configuration file for running the libunwind tests on AIX. # Configuration file for running the libunwind tests on AIX.
# #
lit_config.load_config(config, '@CMAKE_CURRENT_BINARY_DIR@/cmake-bridge.cfg') lit_config.load_config(config, '@CMAKE_CURRENT_BINARY_DIR@/cmake-bridge.cfg')
config.substitutions.append(('%{flags}', '')) config.substitutions.append(('%{flags}', ''))
config.substitutions.append(('%{compile_flags}', config.substitutions.append(('%{compile_flags}',
'-nostdinc++ -I %{include} -I %{cxx-include}' '-nostdinc++ -I %{include}'
)) ))
config.substitutions.append(('%{link_flags}', config.substitutions.append(('%{link_flags}',
'-nostdlib++ -L %{lib} -lunwind -ldl -Wl,-bbigtoc' '-nostdlib++ -L %{lib} -lunwind -ldl -Wl,-bbigtoc'
)) ))
config.substitutions.append(('%{exec}', config.substitutions.append(('%{exec}',
'%{executor} --execdir %T --env LIBPATH=%{lib} -- ' '%{executor} --execdir %T --env LIBPATH=%{lib} -- '
)) ))
Show All 9 Lines