[ELF2] - output of all unknown arguments instead of only one

[grimar]

Summary

I suggest to report all unknown arguments before exit(1), that is helpful for debugging.

[• rafael]

• for (auto *Arg : Args.filtered(OPT_UNKNOWN))
• error(Twine("unknown argument: ") + Arg->getSpelling());

+
+ auto unknowns = Args.filtered(OPT_UNKNOWN);
+ for (llvm::opt::arg_iterator Arg = unknowns.begin(), End = unknowns.end(); Arg != End; ++Arg)
+ warning(Twine("warning: unknown argument: ") + (*Arg)->getSpelling());
+ if (unknowns.begin() != unknowns.end())
+ error(Twine("unknown argument(s) found"));
+

You should still be able to use a range loop:

auto Unknowns = Args.filtered(OPT_UNKNOWN);
for (auto *Arg : Unknows)

....

if (Unkonws.begin() != Unknows.end())
...

[grimar]

Agree. Returned range loop.

[• rafael]

DriverUtils.cpp

62

Variables should start with an upper case letter.

[grimar]

Comment about naming variables addressed.

DriverUtils.cpp

62

Fixed.

[• rafael]

This is fine by me, but Rui should probably be the one to have the final say.

[ruiu]

LGTM with this fix.

DriverUtils.cpp

62

Can you write the real type of Unknowns instead of auto?

[grimar]

• Review comment addressed.
• Fixed code format in Error.cpp

[grimar]

Could you please commit this if it is fine now. I dont have permissions for that yet.

DriverUtils.cpp

62

Done.

[ruiu]

LGTM

DriverUtils.cpp

66

This Twine() is not needed because error() is overloaded both for StringRef and Twine. I'll make that change and submit.

[grimar]

r248524

DriverUtils.cpp

opt::InputArgList ArgParser::parse(ArrayRef<const char *> Argv) {
   unsigned MissingIndex;
   unsigned MissingCount;
 
   opt::InputArgList Args = Table.ParseArgs(Argv, MissingIndex, MissingCount);
   if (MissingCount)
     error(Twine("missing arg value for \"") + Args.getArgString(MissingIndex) +
           "\", expected " + Twine(MissingCount) +
           (MissingCount == 1 ? " argument.\n" : " arguments"));
-  for (auto *Arg : Args.filtered(OPT_UNKNOWN))
-    error(Twine("unknown argument: ") + Arg->getSpelling());
+
+  iterator_range<opt::arg_iterator> Unknowns = Args.filtered(OPT_UNKNOWN);
+  for (auto *Arg : Unknowns)
+    warning(Twine("warning: unknown argument: ") + Arg->getSpelling());
+  if (Unknowns.begin() != Unknowns.end())
+    error(Twine("unknown argument(s) found"));
+
   return Args;
 }

Error.h

 #ifndef LLD_COFF_ERROR_H
 #define LLD_COFF_ERROR_H
 
 #include "lld/Core/LLVM.h"
 
 namespace lld {
 namespace elf2 {
 
+void warning(const Twine &Msg);
+
 LLVM_ATTRIBUTE_NORETURN void error(const Twine &Msg);
 void error(std::error_code EC, const Twine &Prefix);
 void error(std::error_code EC);
 
 template <typename T> void error(const ErrorOr<T> &V, const Twine &Prefix) {
   error(V.getError(), Prefix);
 }
 template <typename T> void error(const ErrorOr<T> &V) { error(V.getError()); }
 
 } // namespace elf2
 } // namespace lld
 
 #endif

Error.cpp

 #include "Error.h"
 
 #include "llvm/ADT/Twine.h"
 #include "llvm/Support/raw_ostream.h"
 
 namespace lld {
 namespace elf2 {
 
+void warning(const Twine &Msg) { llvm::errs() << Msg << "\n"; }
+
 void error(const Twine &Msg) {
   llvm::errs() << Msg << "\n";
   exit(1);
 }
 
 void error(std::error_code EC, const Twine &Prefix) {
   if (!EC)
     return;