This is an archive of the discontinued LLVM Phabricator instance.

[NFC][trace] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API changes
ClosedPublic

Authored by jj10306 on Aug 1 2022, 11:47 AM.

Details

Summary

D130309 introduced changes to the FileSpec API which broke usages of
GetCString() in TraceIntelPTBundleSaver.cpp. This diff replaces usages
of GetCString() with GetPath().c_str() as suggested by D130309.

Test Plan:
Building with the trace plug-in now succeeds

Diff Detail

Event Timeline

jj10306 created this revision.Aug 1 2022, 11:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2022, 11:47 AM
jj10306 requested review of this revision.Aug 1 2022, 11:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2022, 11:47 AM
jj10306 retitled this revision from [trace][intelpt] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API changes to [NFC][trace] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API changes.Aug 1 2022, 11:48 AM
wallace accepted this revision.Aug 1 2022, 11:48 AM

thanks!

This revision is now accepted and ready to land.Aug 1 2022, 11:48 AM
persona0220 accepted this revision.Aug 1 2022, 11:50 AM