This is an archive of the discontinued LLVM Phabricator instance.

[libc++][NFC] Replace macros in vector
ClosedPublic

Authored by philnik on Jul 31 2022, 8:53 AM.

Details

Reviewers
ldionne
Mordante
Group Reviewers
Restricted Project
Commits
rG499fca3cfc88: [libc++][NFC] Replace macros in vector

Diff Detail

Event Timeline

philnik created this revision.Jul 31 2022, 8:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2022, 8:53 AM
philnik requested review of this revision.Jul 31 2022, 8:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2022, 8:53 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision as: Mordante.Aug 2 2022, 10:55 AM

In general I'm happy with this patch. But I wonder whether this is the best timing. We just landed a big vector patches in the LLVM 15 branch. If we need to backport followup patches this patch might result in conflicts.

Therefore I leave the final approval to @ldionne.

libcxx/include/vector
358

The current change breaks the alignment. Do you intend to switch to using in a followup?

ldionne accepted this revision.Aug 11 2022, 9:59 AM
This revision is now accepted and ready to land.Aug 11 2022, 9:59 AM
This revision was automatically updated to reflect the committed changes.
philnik marked an inline comment as done.
philnik added inline comments.Aug 11 2022, 11:23 AM
libcxx/include/vector
358

I didn't plan to, but I'll make a patch.