Details
Details
- Reviewers
ldionne Mordante - Group Reviewers
Restricted Project - Commits
- rG499fca3cfc88: [libc++][NFC] Replace macros in vector
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
In general I'm happy with this patch. But I wonder whether this is the best timing. We just landed a big vector patches in the LLVM 15 branch. If we need to backport followup patches this patch might result in conflicts.
Therefore I leave the final approval to @ldionne.
libcxx/include/vector | ||
---|---|---|
358 | The current change breaks the alignment. Do you intend to switch to using in a followup? |
libcxx/include/vector | ||
---|---|---|
358 | I didn't plan to, but I'll make a patch. |
The current change breaks the alignment. Do you intend to switch to using in a followup?