[ADT] Deprecate Optional::hasValue (NFC)

[kazu]

This patch was superceded by b5f8d42efe3e246d582d4a1a328fac915e4ce8dc.

llvm/include/llvm/ADT/Optional.h

public:
   void reset() noexcept {
     if (hasVal) {
       val.~T();
       hasVal = false;
     }
   }
 
   constexpr bool has_value() const noexcept { return hasVal; }
-  constexpr bool hasValue() const noexcept { return hasVal; }
+  [[deprecated("Use has_value instead.")]] constexpr bool
+  hasValue() const noexcept {
+    return hasVal;
+  }
 
   T &value() &noexcept {
     assert(hasVal);
     return val;
   }
   T &getValue() &noexcept {
     assert(hasVal);
     return val;
public:
   void reset() noexcept {
     if (hasVal) {
       val.~T();
       hasVal = false;
     }
   }
 
   constexpr bool has_value() const noexcept { return hasVal; }
-  constexpr bool hasValue() const noexcept { return hasVal; }
+  [[deprecated("Use has_value instead.")]] constexpr bool
+  hasValue() const noexcept {
+    return hasVal;
+  }
 
   T &value() &noexcept {
     assert(hasVal);
     return val;
   }
   T &getValue() &noexcept {
     assert(hasVal);
     return val;
public:
   T *getPointer() { return &Storage.value(); }
   constexpr const T &value() const & { return Storage.value(); }
   constexpr const T &getValue() const & { return Storage.value(); }
   T &value() & { return Storage.value(); }
   T &getValue() & { return Storage.value(); }
 
   constexpr explicit operator bool() const { return has_value(); }
   constexpr bool has_value() const { return Storage.has_value(); }
-  constexpr bool hasValue() const { return Storage.has_value(); }
+  [[deprecated("Use has_value instead.")]] constexpr bool hasValue() const {
+    return Storage.has_value();
+  }
   constexpr const T *operator->() const { return getPointer(); }
   T *operator->() { return getPointer(); }
   constexpr const T &operator*() const & { return value(); }
   T &operator*() & { return value(); }
 
   template <typename U> constexpr T value_or(U &&alt) const & {
     return has_value() ? value() : std::forward<U>(alt);
   }