This is an archive of the discontinued LLVM Phabricator instance.

Differential D130792

[libc++][format] Enables feature-test macro.
ClosedPublic

Authored by Mordante on Jul 29 2022, 11:36 AM.

Details

Reviewers
ldionne
vitaut
Group Reviewers
Restricted Project
Commits
rG679169b7dd74: [libc++][format] Enables feature-test macro.
Summary

The macro is only enabled when the Clang is used with
-fexperimental-library.

Diff Detail

Event Timeline

Mordante created this revision.Jul 29 2022, 11:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2022, 11:37 AM
Herald added a subscriber: arichardson. · View Herald Transcript
Harbormaster completed remote builds in B178331: Diff 448693.Jul 29 2022, 1:52 PM
Mordante published this revision for review.Aug 1 2022, 8:50 AM
Mordante added reviewers: ldionne, vitaut.
Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2022, 8:50 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ldionne accepted this revision.Aug 2 2022, 9:02 AM
This revision is now accepted and ready to land.Aug 2 2022, 9:02 AM
Closed by commit rG679169b7dd74: [libc++][format] Enables feature-test macro. (authored by Mordante). · Explain WhyAug 2 2022, 9:43 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG679169b7dd74: [libc++][format] Enables feature-test macro..

Revision Contents

PathSize
libcxx/
docs/
2 lines
include/
4 lines
test/
std/
language.support/
support.limits/
support.limits.general/
12 lines
12 lines
utils/
5 lines

Diff 449317

libcxx/docs/FeatureTestMacroTable.rst

Show First 20 Lines • Show All 228 Lines • ▼ Show 20 Lines.. table:: Current Status
``__cpp_lib_destroying_delete`` ``201806L`` ``__cpp_lib_destroying_delete`` ``201806L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_endian`` ``201907L`` ``__cpp_lib_endian`` ``201907L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_erase_if`` ``202002L`` ``__cpp_lib_erase_if`` ``202002L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_execution`` *unimplemented* ``__cpp_lib_execution`` *unimplemented*
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_format`` *unimplemented* ``__cpp_lib_format`` ``202106L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_generic_unordered_lookup`` ``201811L`` ``__cpp_lib_generic_unordered_lookup`` ``201811L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_int_pow2`` ``202002L`` ``__cpp_lib_int_pow2`` ``202002L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_integer_comparison_functions`` ``202002L`` ``__cpp_lib_integer_comparison_functions`` ``202002L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_interpolate`` ``201902L`` ``__cpp_lib_interpolate`` ``201902L``
▲ Show 20 Lines • Show All 112 Lines • Show Last 20 Lines

libcxx/include/version

Show First 20 Lines • Show All 325 Lines • ▼ Show 20 Lines
# define __cpp_lib_coroutine 201902L # define __cpp_lib_coroutine 201902L
# if _LIBCPP_STD_VER > 17 && defined(__cpp_impl_destroying_delete) && __cpp_impl_destroying_delete >= 201806L # if _LIBCPP_STD_VER > 17 && defined(__cpp_impl_destroying_delete) && __cpp_impl_destroying_delete >= 201806L
# define __cpp_lib_destroying_delete 201806L # define __cpp_lib_destroying_delete 201806L
# endif # endif
# define __cpp_lib_endian 201907L # define __cpp_lib_endian 201907L
# define __cpp_lib_erase_if 202002L # define __cpp_lib_erase_if 202002L
# undef __cpp_lib_execution # undef __cpp_lib_execution
// # define __cpp_lib_execution 201902L // # define __cpp_lib_execution 201902L
# if !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) # if !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)
// # define __cpp_lib_format 202106L # define __cpp_lib_format 202106L
# endif # endif
# define __cpp_lib_generic_unordered_lookup 201811L # define __cpp_lib_generic_unordered_lookup 201811L
# define __cpp_lib_int_pow2 202002L # define __cpp_lib_int_pow2 202002L
# define __cpp_lib_integer_comparison_functions 202002L # define __cpp_lib_integer_comparison_functions 202002L
# define __cpp_lib_interpolate 201902L # define __cpp_lib_interpolate 201902L
# define __cpp_lib_is_constant_evaluated 201811L # define __cpp_lib_is_constant_evaluated 201811L
// # define __cpp_lib_is_layout_compatible 201907L // # define __cpp_lib_is_layout_compatible 201907L
# define __cpp_lib_is_nothrow_convertible 201806L # define __cpp_lib_is_nothrow_convertible 201806L
▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines

libcxx/test/std/language.support/support.limits/support.limits.general/format.version.compile.pass.cpp

Show All 38 Lines
#elif TEST_STD_VER == 17 #elif TEST_STD_VER == 17
# ifdef __cpp_lib_format # ifdef __cpp_lib_format
# error "__cpp_lib_format should not be defined before c++20" # error "__cpp_lib_format should not be defined before c++20"
# endif # endif
#elif TEST_STD_VER == 20 #elif TEST_STD_VER == 20
# if !defined(_LIBCPP_VERSION) # if !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)
# ifndef __cpp_lib_format # ifndef __cpp_lib_format
# error "__cpp_lib_format should be defined in c++20" # error "__cpp_lib_format should be defined in c++20"
# endif # endif
# if __cpp_lib_format != 202106L # if __cpp_lib_format != 202106L
# error "__cpp_lib_format should have the value 202106L in c++20" # error "__cpp_lib_format should have the value 202106L in c++20"
# endif # endif
# else // _LIBCPP_VERSION # else
# ifdef __cpp_lib_format # ifdef __cpp_lib_format
# error "__cpp_lib_format should not be defined because it is unimplemented in libc++!" # error "__cpp_lib_format should not be defined when !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT) is not defined!"
# endif # endif
# endif # endif
#elif TEST_STD_VER > 20 #elif TEST_STD_VER > 20
# if !defined(_LIBCPP_VERSION) # if !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)
# ifndef __cpp_lib_format # ifndef __cpp_lib_format
# error "__cpp_lib_format should be defined in c++2b" # error "__cpp_lib_format should be defined in c++2b"
# endif # endif
# if __cpp_lib_format != 202106L # if __cpp_lib_format != 202106L
# error "__cpp_lib_format should have the value 202106L in c++2b" # error "__cpp_lib_format should have the value 202106L in c++2b"
# endif # endif
# else // _LIBCPP_VERSION # else
# ifdef __cpp_lib_format # ifdef __cpp_lib_format
# error "__cpp_lib_format should not be defined because it is unimplemented in libc++!" # error "__cpp_lib_format should not be defined when !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT) is not defined!"
# endif # endif
# endif # endif
#endif // TEST_STD_VER > 20 #endif // TEST_STD_VER > 20

libcxx/test/std/language.support/support.limits/support.limits.general/version.version.compile.pass.cpp

Show First 20 Lines • Show All 2,811 Lines • ▼ Show 20 Lines
# error "__cpp_lib_filesystem should have the value 201703L in c++20" # error "__cpp_lib_filesystem should have the value 201703L in c++20"
# endif # endif
# else # else
# ifdef __cpp_lib_filesystem # ifdef __cpp_lib_filesystem
# error "__cpp_lib_filesystem should not be defined when !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_filesystem) is not defined!" # error "__cpp_lib_filesystem should not be defined when !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_filesystem) is not defined!"
# endif # endif
# endif # endif
# if !defined(_LIBCPP_VERSION) # if !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)
# ifndef __cpp_lib_format # ifndef __cpp_lib_format
# error "__cpp_lib_format should be defined in c++20" # error "__cpp_lib_format should be defined in c++20"
# endif # endif
# if __cpp_lib_format != 202106L # if __cpp_lib_format != 202106L
# error "__cpp_lib_format should have the value 202106L in c++20" # error "__cpp_lib_format should have the value 202106L in c++20"
# endif # endif
# else // _LIBCPP_VERSION # else
# ifdef __cpp_lib_format # ifdef __cpp_lib_format
# error "__cpp_lib_format should not be defined because it is unimplemented in libc++!" # error "__cpp_lib_format should not be defined when !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT) is not defined!"
# endif # endif
# endif # endif
# ifndef __cpp_lib_gcd_lcm # ifndef __cpp_lib_gcd_lcm
# error "__cpp_lib_gcd_lcm should be defined in c++20" # error "__cpp_lib_gcd_lcm should be defined in c++20"
# endif # endif
# if __cpp_lib_gcd_lcm != 201606L # if __cpp_lib_gcd_lcm != 201606L
# error "__cpp_lib_gcd_lcm should have the value 201606L in c++20" # error "__cpp_lib_gcd_lcm should have the value 201606L in c++20"
▲ Show 20 Lines • Show All 1,211 Lines • ▼ Show 20 Lines
# error "__cpp_lib_filesystem should have the value 201703L in c++2b" # error "__cpp_lib_filesystem should have the value 201703L in c++2b"
# endif # endif
# else # else
# ifdef __cpp_lib_filesystem # ifdef __cpp_lib_filesystem
# error "__cpp_lib_filesystem should not be defined when !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_filesystem) is not defined!" # error "__cpp_lib_filesystem should not be defined when !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_filesystem) is not defined!"
# endif # endif
# endif # endif
# if !defined(_LIBCPP_VERSION) # if !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)
# ifndef __cpp_lib_format # ifndef __cpp_lib_format
# error "__cpp_lib_format should be defined in c++2b" # error "__cpp_lib_format should be defined in c++2b"
# endif # endif
# if __cpp_lib_format != 202106L # if __cpp_lib_format != 202106L
# error "__cpp_lib_format should have the value 202106L in c++2b" # error "__cpp_lib_format should have the value 202106L in c++2b"
# endif # endif
# else // _LIBCPP_VERSION # else
# ifdef __cpp_lib_format # ifdef __cpp_lib_format
# error "__cpp_lib_format should not be defined because it is unimplemented in libc++!" # error "__cpp_lib_format should not be defined when !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT) is not defined!"
# endif # endif
# endif # endif
# ifndef __cpp_lib_gcd_lcm # ifndef __cpp_lib_gcd_lcm
# error "__cpp_lib_gcd_lcm should be defined in c++2b" # error "__cpp_lib_gcd_lcm should be defined in c++2b"
# endif # endif
# if __cpp_lib_gcd_lcm != 201606L # if __cpp_lib_gcd_lcm != 201606L
# error "__cpp_lib_gcd_lcm should have the value 201606L in c++2b" # error "__cpp_lib_gcd_lcm should have the value 201606L in c++2b"
▲ Show 20 Lines • Show All 875 Lines • Show Last 20 Lines

libcxx/utils/generate_feature_test_macro_components.py

Show First 20 Lines • Show All 305 Lines • ▼ Show 20 Linesfeature_test_macros = [ add_version_header(x) for x in [
"values": { "c++17": 201703 }, "values": { "c++17": 201703 },
"headers": ["filesystem"], "headers": ["filesystem"],
"test_suite_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_filesystem)", "test_suite_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_filesystem)",
"libcxx_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_filesystem)" "libcxx_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_filesystem)"
}, { }, {
"name": "__cpp_lib_format", "name": "__cpp_lib_format",
"values": { "c++20": 202106 }, "values": { "c++20": 202106 },
"headers": ["format"], "headers": ["format"],
"test_suite_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format)", "test_suite_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)",
"libcxx_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format)", "libcxx_guard": "!defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)",
"unimplemented": True,
}, { }, {
"name": "__cpp_lib_gcd_lcm", "name": "__cpp_lib_gcd_lcm",
"values": { "c++17": 201606 }, "values": { "c++17": 201606 },
"headers": ["numeric"], "headers": ["numeric"],
}, { }, {
"name": "__cpp_lib_generic_associative_lookup", "name": "__cpp_lib_generic_associative_lookup",
"values": { "c++14": 201304 }, "values": { "c++14": 201304 },
"headers": ["map", "set"], "headers": ["map", "set"],
▲ Show 20 Lines • Show All 883 Lines • Show Last 20 Lines