This is an archive of the discontinued LLVM Phabricator instance.

Differential D130606

[lld-macho] Fix -bitcode_process_mode arg type
ClosedPublic

Authored by keith on Jul 26 2022, 4:19 PM.

Details

Reviewers
int3
Group Reviewers
Restricted Project
Commits
rGe3857791a7af: [lld-macho] Fix -bitcode_process_mode arg type
Summary

This is still undocumented and unsupported, but if someone passed it
before you would end up with a missing file error since this takes an
argument that wouldn't be handled.

Diff Detail

Event Timeline

keith created this revision.Jul 26 2022, 4:19 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 26 2022, 4:19 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
keith requested review of this revision.Jul 26 2022, 4:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2022, 4:19 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B177743: Diff 447873.Jul 26 2022, 4:35 PM
int3 accepted this revision.Jul 26 2022, 6:13 PM
int3 added a subscriber: int3.

Thanks!

This revision is now accepted and ready to land.Jul 26 2022, 6:13 PM
Closed by commit rGe3857791a7af: [lld-macho] Fix -bitcode_process_mode arg type (authored by keith). · Explain WhyJul 26 2022, 8:59 PM
This revision was automatically updated to reflect the committed changes.
keith added a commit: rGe3857791a7af: [lld-macho] Fix -bitcode_process_mode arg type.

Revision Contents

PathSize
lld/
MachO/
2 lines

Diff 447873

lld/MachO/Options.td

Show First 20 Lines • Show All 1,176 Lines • ▼ Show 20 Lines
def allow_dead_duplicates : Flag<["-"], "allow_dead_duplicates">, def allow_dead_duplicates : Flag<["-"], "allow_dead_duplicates">,
HelpText<"This option is undocumented in ld64">, HelpText<"This option is undocumented in ld64">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_undocumented>; Group<grp_undocumented>;
def allow_simulator_linking_to_macosx_dylibs : Flag<["-"], "allow_simulator_linking_to_macosx_dylibs">, def allow_simulator_linking_to_macosx_dylibs : Flag<["-"], "allow_simulator_linking_to_macosx_dylibs">,
HelpText<"This option is undocumented in ld64">, HelpText<"This option is undocumented in ld64">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_undocumented>; Group<grp_undocumented>;
def bitcode_process_mode : Flag<["-"], "bitcode_process_mode">, def bitcode_process_mode : Separate<["-"], "bitcode_process_mode">,
HelpText<"This option is undocumented in ld64">, HelpText<"This option is undocumented in ld64">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_undocumented>; Group<grp_undocumented>;
def bitcode_verify : Flag<["-"], "bitcode_verify">, def bitcode_verify : Flag<["-"], "bitcode_verify">,
HelpText<"This option is undocumented in ld64">, HelpText<"This option is undocumented in ld64">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_undocumented>; Group<grp_undocumented>;
def classic_linker : Flag<["-"], "classic_linker">, def classic_linker : Flag<["-"], "classic_linker">,
▲ Show 20 Lines • Show All 161 Lines • Show Last 20 Lines