Details
Details
- Reviewers
ldionne huixie90 philnik - Group Reviewers
Restricted Project - Commits
- rG760d2b462c04: [libc++][ranges] Implement `ranges::remove_copy{, _if}`.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
- finalise ranges::remove_copy{_if}
- fixed a bug where ranges::remove_copy_if got the predicate inverted
- enabled all the "robust" tests
- added tests for ranges::remove_copy_if
libcxx/include/algorithm | ||
---|---|---|
880 | Missing the definition of remove_copy_result. | |
libcxx/test/std/algorithms/alg.modifying.operations/alg.remove/ranges_remove_copy.pass.cpp | ||
50 | Needs tests for indirectly_copyable and indirect_binary_predicate. | |
214 | Need to count invocations of the predicate as well. | |
libcxx/test/std/algorithms/alg.modifying.operations/alg.remove/ranges_remove_copy_if.pass.cpp | ||
62 | This should be made consistent with the other test file. | |
220–221 | These two files should ideally be almost mirror versions of each other. |
Missing the definition of remove_copy_result.