This is an archive of the discontinued LLVM Phabricator instance.

[flang] Add semantics test for ERROR STOP statement
ClosedPublic

Authored by ngeorge1098 on Jul 25 2022, 4:34 PM.

Diff Detail

Event Timeline

ngeorge1098 created this revision.Jul 25 2022, 4:34 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: jdoerfert. · View Herald Transcript
ngeorge1098 requested review of this revision.Jul 25 2022, 4:34 PM

Add standard conforming statements that use parentheses around the stop-code.
Add standard non-conforming statements that use parentheses around all arguments.

Add standards-conforming statements for integer expressions
and character phrases. Add standards non-conforming statement
for using quiet= without stop-code. Change language of
comments to properly reflect the language of the standards.

ktras added a comment.Jul 28 2022, 1:26 PM

Test looks great, but I would suggest adding non-conforming statements where the stop-code is not of the default integer kind, thus testing C1171 from the Fortran 2018 Standard, and adding a stop-code where it is not of the default char kind, thus testing the definition of one of the options for a stop code, which is scalar-default-char-expr.

Add standard-non-conforming statements for stop-code integer not being
of default kind and stop-code character not being of default kind.

ktras accepted this revision.Aug 1 2022, 9:53 AM

LGTM

This revision is now accepted and ready to land.Aug 1 2022, 9:53 AM
This revision was automatically updated to reflect the committed changes.