This is an archive of the discontinued LLVM Phabricator instance.

[CMake][Fuchsia] Enable assertions and backtraces in stage 1 build
ClosedPublic

Authored by abrachet on Jul 25 2022, 1:20 PM.

Diff Detail

Event Timeline

abrachet created this revision.Jul 25 2022, 1:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2022, 1:20 PM
Herald added a subscriber: mgorny. · View Herald Transcript
abrachet requested review of this revision.Jul 25 2022, 1:20 PM

I also found D120280 where we disabled assertions. Are you still of the opinion that we can enable these or does that remind you of whatever it was you found back then?

phosek accepted this revision.Jul 25 2022, 11:03 PM

LGTM I'm fine enabling them for the first stage, but we should keep an eye on the build times after this lands.

This revision is now accepted and ready to land.Jul 25 2022, 11:03 PM
This revision was landed with ongoing or failed builds.Jul 25 2022, 11:09 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2022, 11:09 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript