This is an archive of the discontinued LLVM Phabricator instance.

Differential D130476

[NFC] Fix some C++20 warnings
ClosedPublic

Authored by Godin on Jul 25 2022, 5:18 AM.

Details

Reviewers
aaron.ballman
Commits
rGba198e35fd38: [NFC] Fix some C++20 warnings
Summary

Without this patch when using CMAKE_CXX_STANDARD=20 Microsoft compiler produces following warnings

clang\include\clang/Basic/DiagnosticIDs.h(48): warning C5054: operator '+': deprecated between enumerations of different types
clang\include\clang/Basic/DiagnosticIDs.h(49): warning C5054: operator '+': deprecated between enumerations of different types
clang\include\clang/Basic/DiagnosticIDs.h(50): warning C5054: operator '+': deprecated between enumerations of different types
clang\include\clang/Basic/DiagnosticIDs.h(51): warning C5054: operator '+': deprecated between enumerations of different types
clang\include\clang/Basic/DiagnosticIDs.h(52): warning C5054: operator '+': deprecated between enumerations of different types
clang\include\clang/Basic/DiagnosticIDs.h(53): warning C5054: operator '+': deprecated between enumerations of different types
clang\include\clang/Basic/DiagnosticIDs.h(54): warning C5054: operator '+': deprecated between enumerations of different types
clang\include\clang/Basic/DiagnosticIDs.h(55): warning C5054: operator '+': deprecated between enumerations of different types
clang\include\clang/Basic/DiagnosticIDs.h(56): warning C5054: operator '+': deprecated between enumerations of different types
clang\include\clang/Basic/DiagnosticIDs.h(57): warning C5054: operator '+': deprecated between enumerations of different types
clang\include\clang/Basic/DiagnosticIDs.h(58): warning C5054: operator '+': deprecated between enumerations of different types
clang\include\clang/Basic/DiagnosticIDs.h(59): warning C5054: operator '+': deprecated between enumerations of different types

Diff Detail

Event Timeline

Godin created this revision.Jul 25 2022, 5:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2022, 5:18 AM
Godin requested review of this revision.Jul 25 2022, 5:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2022, 5:18 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B177340: Diff 447285.Jul 25 2022, 6:19 AM
Godin added a reviewer: aaron.ballman.Jul 26 2022, 2:48 AM
aaron.ballman accepted this revision.Jul 26 2022, 3:53 AM

LGTM, thank you!

This revision is now accepted and ready to land.Jul 26 2022, 3:53 AM
Godin added a comment.Jul 26 2022, 4:13 AM

@aaron.ballman thanks for the review! could you please commit this on my behalf since I do not have commit rights?

This revision was landed with ongoing or failed builds.Jul 26 2022, 5:04 AM
Closed by commit rGba198e35fd38: [NFC] Fix some C++20 warnings (authored by Godin, committed by steakhal). · Explain Why
This revision was automatically updated to reflect the committed changes.
steakhal added a commit: rGba198e35fd38: [NFC] Fix some C++20 warnings.

Revision Contents

PathSize
clang/
include/
clang/
Basic/
24 lines

Diff 447648

clang/include/clang/Basic/DiagnosticIDs.h

Show All 39 Lines enum {
DIAG_SIZE_CROSSTU = 100, DIAG_SIZE_CROSSTU = 100,
DIAG_SIZE_SEMA = 4500, DIAG_SIZE_SEMA = 4500,
DIAG_SIZE_ANALYSIS = 100, DIAG_SIZE_ANALYSIS = 100,
DIAG_SIZE_REFACTORING = 1000, DIAG_SIZE_REFACTORING = 1000,
}; };
// Start position for diagnostics. // Start position for diagnostics.
enum { enum {
DIAG_START_COMMON = 0, DIAG_START_COMMON = 0,
DIAG_START_DRIVER = DIAG_START_COMMON + DIAG_SIZE_COMMON, DIAG_START_DRIVER = DIAG_START_COMMON + static_cast<int>(DIAG_SIZE_COMMON),
DIAG_START_FRONTEND = DIAG_START_DRIVER + DIAG_SIZE_DRIVER, DIAG_START_FRONTEND = DIAG_START_DRIVER + static_cast<int>(DIAG_SIZE_DRIVER),
DIAG_START_SERIALIZATION = DIAG_START_FRONTEND + DIAG_SIZE_FRONTEND, DIAG_START_SERIALIZATION = DIAG_START_FRONTEND + static_cast<int>(DIAG_SIZE_FRONTEND),
DIAG_START_LEX = DIAG_START_SERIALIZATION + DIAG_SIZE_SERIALIZATION, DIAG_START_LEX = DIAG_START_SERIALIZATION + static_cast<int>(DIAG_SIZE_SERIALIZATION),
DIAG_START_PARSE = DIAG_START_LEX + DIAG_SIZE_LEX, DIAG_START_PARSE = DIAG_START_LEX + static_cast<int>(DIAG_SIZE_LEX),
DIAG_START_AST = DIAG_START_PARSE + DIAG_SIZE_PARSE, DIAG_START_AST = DIAG_START_PARSE + static_cast<int>(DIAG_SIZE_PARSE),
DIAG_START_COMMENT = DIAG_START_AST + DIAG_SIZE_AST, DIAG_START_COMMENT = DIAG_START_AST + static_cast<int>(DIAG_SIZE_AST),
DIAG_START_CROSSTU = DIAG_START_COMMENT + DIAG_SIZE_COMMENT, DIAG_START_CROSSTU = DIAG_START_COMMENT + static_cast<int>(DIAG_SIZE_COMMENT),
DIAG_START_SEMA = DIAG_START_CROSSTU + DIAG_SIZE_CROSSTU, DIAG_START_SEMA = DIAG_START_CROSSTU + static_cast<int>(DIAG_SIZE_CROSSTU),
DIAG_START_ANALYSIS = DIAG_START_SEMA + DIAG_SIZE_SEMA, DIAG_START_ANALYSIS = DIAG_START_SEMA + static_cast<int>(DIAG_SIZE_SEMA),
DIAG_START_REFACTORING = DIAG_START_ANALYSIS + DIAG_SIZE_ANALYSIS, DIAG_START_REFACTORING = DIAG_START_ANALYSIS + static_cast<int>(DIAG_SIZE_ANALYSIS),
DIAG_UPPER_LIMIT = DIAG_START_REFACTORING + DIAG_SIZE_REFACTORING DIAG_UPPER_LIMIT = DIAG_START_REFACTORING + static_cast<int>(DIAG_SIZE_REFACTORING)
}; };
class CustomDiagInfo; class CustomDiagInfo;
/// All of the diagnostics that can be emitted by the frontend. /// All of the diagnostics that can be emitted by the frontend.
typedef unsigned kind; typedef unsigned kind;
// Get typedefs for common diagnostics. // Get typedefs for common diagnostics.
▲ Show 20 Lines • Show All 299 Lines • Show Last 20 Lines