Page MenuHomePhabricator

[Lit] Pass through DFLTCC from the surrounding environment
ClosedPublic

Authored by iii on Jul 21 2022, 5:02 AM.

Details

Summary

Many distros ship zlib with the IBM Z deflate hardware acceleration
patch [1]. Sometimes it's desirable to disable the acceleration, for
example, for reproducibility. This can be done by exporting DFLTCC=0.
llvm-lit clears this environment variable, which causes
compress-debug-sections-zlib.test fail on z15 and later machines. Add
DFLTCC to the list of variables to keep.

[1] https://github.com/madler/zlib/pull/410

Diff Detail

Event Timeline

iii created this revision.Jul 21 2022, 5:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2022, 5:02 AM
Herald added a subscriber: delcypher. · View Herald Transcript
iii requested review of this revision.Jul 21 2022, 5:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2022, 5:02 AM
abrachet accepted this revision.Jul 22 2022, 11:02 AM
This revision is now accepted and ready to land.Jul 22 2022, 11:02 AM
This revision was landed with ongoing or failed builds.Jul 22 2022, 4:39 PM
This revision was automatically updated to reflect the committed changes.