Use fcntl.h to retrieve the O_CREAT and O_RDRW constants.

[vkalintiris]

Summary

Normally, these macros are defined in fnctl.h. However, GLIBC exposes their
definition through <sys/file.h> too. This change allows us to compile LLDB
with non-GLIBC C libraries.

[emaste]

LGTM

Although it ought to remain on the same line, no?

[vkalintiris]

Use fcntl.h instead of sys/fcntl.h.

[vkalintiris]

In D13022#249823, @emaste wrote:

Although it ought to remain on the same line, no?

It shouldn't matter in this case. I just followed the order of the headers in the synopsis section of shm_open(3) on my system.
However, I noticed that we should use fcntl.h instead of sys/fcntl.h. The former is POSIX-compatible while the latter (based on my understanding) is being used to expose additional kernel-defines in some systems. Does this look good to you?

[emaste]

Yes, updated change LGTM.

[clayborg]

Looks good.

[krytarowski]

You mean O_RDWR, not O_RDRW.

The patch is correct on NetBSD.

source/Core/ConnectionSharedMemory.cpp

 #include "lldb/Core/ConnectionSharedMemory.h"
 
 // C Includes
 #include <errno.h>
 #include <stdlib.h>
 #ifdef _WIN32
 #include "lldb/Host/windows/windows.h"
 #else
-#include <sys/file.h>
 #include <sys/mman.h>
 #include <sys/stat.h>
 #include <sys/types.h>
+#include <fcntl.h>
 #endif
 
 // C++ Includes
 // Other libraries and framework includes
 // Project includes
 #include "llvm/Support/MathExtras.h"
 #include "lldb/Core/Communication.h"
 #include "lldb/Core/Log.h"