Page MenuHomePhabricator

[clang-format] Allow custom attributes in access specifiers
Needs ReviewPublic

Authored by eoanermine on Jul 15 2022, 4:02 AM.

Details

Summary
  • Allow custom attributes in access specifiers
  • Add tests for custom attributes in access specifiers
  • Add more tests for correct handling of Qt's signals and slots

Fixes https://github.com/llvm/llvm-project/issues/37751

Diff Detail

Event Timeline

eoanermine created this revision.Jul 15 2022, 4:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2022, 4:02 AM
eoanermine requested review of this revision.Jul 15 2022, 4:02 AM
eoanermine edited the summary of this revision. (Show Details)Jul 15 2022, 4:02 AM
curdeius edited the summary of this revision. (Show Details)Jul 15 2022, 5:38 AM
curdeius added a reviewer: MyDeveloperDay.
curdeius added inline comments.Jul 15 2022, 5:42 AM
clang/unittests/Format/FormatTest.cpp
3304

How about multiple macros?
E.g. public ATTR1 ATTR2?

curdeius retitled this revision from Allow custom attributes in access specifiers to [clang-format] Allow custom attributes in access specifiers.Jul 15 2022, 5:46 AM
curdeius added inline comments.
clang/unittests/Format/FormatTest.cpp
3298

In the same vein, could you add test for slots: and Q_SLOTS: please?