This is an archive of the discontinued LLVM Phabricator instance.

[Flang] Fix path strings in CreateFIRLangRef.py
ClosedPublic

Authored by DylanFleming-arm on Jul 13 2022, 7:32 AM.

Details

Summary

In D129186, CreateFIRLangRef.py was created to help fix
formatting problems with FIRLangRef.md.

However, due to an error while rebasing, the last edit was lost,
as such the current path variables are Unix-style.

This patch addresses what was discussed in the previous patch and
now uses os.path.join instead.

Diff Detail

Event Timeline

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 13 2022, 7:32 AM
DylanFleming-arm requested review of this revision.Jul 13 2022, 7:32 AM
flang/docs/FIR/CreateFIRLangRef.py
6

This comment seems to imply that the path should be "../", but it isn't. Is the comment or the paths incorect? :)

Ah, I meant it as from the binary working directory, as this file exists in both src and bin, and is copied over at build time, before being ran.
The comment itself is probably not needed, but without it, 'Dialect/FIRLangref.md' might seem like a non-existant file.

Updated comment to better explain where the paths are relative to.

Fixed typo 'exectued' to 'executed'

This revision is now accepted and ready to land.Jul 13 2022, 8:24 AM
This revision was landed with ongoing or failed builds.Jul 13 2022, 8:29 AM
This revision was automatically updated to reflect the committed changes.