Page MenuHomePhabricator

[mips] Allow constant expressions in second argument of .cpsetup.
ClosedPublic

Authored by dsanders on Sep 18 2015, 2:38 AM.

Details

Summary

Also tightened up the test and made a trivial fix to prevent double-newline
after emitting .cpsetup directives.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 35069.Sep 18 2015, 2:38 AM
dsanders retitled this revision from to [mips] Allow constant expressions in second argument of .cpsetup..
dsanders updated this object.
dsanders added a reviewer: vkalintiris.
dsanders added subscribers: llvm-commits, emaste, seanbruno.

This does the right thing over here in FreeBSD land. Commit and fire when ready.

vkalintiris accepted this revision.Sep 21 2015, 2:14 AM
vkalintiris edited edge metadata.

LGTM.

test/MC/Mips/cpsetup.s
36

It seems that FileCheck does not complain when there's no any previous check line with the same check prefix as the one used with the -NEXT directive. However, could we remove that in order to make explicit the places where we begin to check with a check prefix? There are two-three such cases below too.

This revision is now accepted and ready to land.Sep 21 2015, 2:14 AM
dsanders closed this revision.Sep 21 2015, 2:28 AM