This is an archive of the discontinued LLVM Phabricator instance.

Differential D129270

[libcxx] [test] Don't disable libc++experimental in mingw builds
ClosedPublic

Authored by mstorsjo on Jul 7 2022, 3:32 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG5b32e4755959: [libcxx] [ci] Don't disable libc++experimental in mingw builds
Summary

Since dfa88927ae1411ccc3b248b7e624f2acf623d947, the static libc++experimental
should work in mingw dll builds. (It probably worked all along in static
mingw builds.)

Diff Detail

Event Timeline

mstorsjo created this revision.Jul 7 2022, 3:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 3:32 AM
Herald added a subscriber: mgorny. · View Herald Transcript
mstorsjo requested review of this revision.Jul 7 2022, 3:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 3:32 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
mstorsjo added a child revision: D129271: [libcxx] Make LIBCXX_HERMETIC_STATIC_LIBRARY apply to libc++experimental too.Jul 7 2022, 3:33 AM
Harbormaster completed remote builds in B174106: Diff 442846.Jul 7 2022, 5:21 AM
ldionne accepted this revision.Jul 7 2022, 8:02 AM
This revision is now accepted and ready to land.Jul 7 2022, 8:02 AM
Closed by commit rG5b32e4755959: [libcxx] [ci] Don't disable libc++experimental in mingw builds (authored by mstorsjo). · Explain WhyJul 7 2022, 1:31 PM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG5b32e4755959: [libcxx] [ci] Don't disable libc++experimental in mingw builds.

Revision Contents

PathSize
libcxx/
cmake/
caches/
2 lines

Diff 443045

libcxx/cmake/caches/MinGW.cmake

set(LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY OFF CACHE BOOL "")
set(LIBCXX_CXX_ABI libcxxabi CACHE STRING "") set(LIBCXX_CXX_ABI libcxxabi CACHE STRING "")
set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "") set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
set(LIBCXXABI_ENABLE_SHARED OFF CACHE BOOL "") set(LIBCXXABI_ENABLE_SHARED OFF CACHE BOOL "")
set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "")
set(LIBCXX_USE_COMPILER_RT ON CACHE BOOL "") set(LIBCXX_USE_COMPILER_RT ON CACHE BOOL "")
set(LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "") set(LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "")
set(LIBUNWIND_USE_COMPILER_RT ON CACHE BOOL "") set(LIBUNWIND_USE_COMPILER_RT ON CACHE BOOL "")
set(LIBCXX_TARGET_INFO "libcxx.test.target_info.MingwLocalTI" CACHE STRING "") set(LIBCXX_TARGET_INFO "libcxx.test.target_info.MingwLocalTI" CACHE STRING "")
# Without this flag, 'long double' (which is 80 bit on x86 mingw, but # Without this flag, 'long double' (which is 80 bit on x86 mingw, but
# 64 bit in MSVC) isn't handled correctly in printf. # 64 bit in MSVC) isn't handled correctly in printf.
set(LIBCXX_EXTRA_SITE_DEFINES "__USE_MINGW_ANSI_STDIO=1" CACHE STRING "") set(LIBCXX_EXTRA_SITE_DEFINES "__USE_MINGW_ANSI_STDIO=1" CACHE STRING "")