This is an archive of the discontinued LLVM Phabricator instance.

[gn build] (manually) port 6b3956e123db
ClosedPublic

Authored by peterwaller-arm on Jul 4 2022, 7:19 AM.

Details

Summary

Something missed by the auto-port, I take it?

Diff Detail

Event Timeline

peterwaller-arm created this revision.Jul 4 2022, 7:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2022, 7:19 AM
peterwaller-arm requested review of this revision.Jul 4 2022, 7:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2022, 7:19 AM
thakis added a comment.EditedJul 4 2022, 12:37 PM

The auto-merger only auto-merges source lists, not deps. (See llvm/utils/gn/build/sync_source_lists_from_cmake.py – the merge bot just runs llvm/utils/gn/build/sync_source_lists_from_cmake.py --write, and then commits the result if tests pass.)

llvm/utils/gn/secondary/llvm/tools/llvm-reduce/BUILD.gn
6

Shouldn't this be //llvm/lib/Transforms/IPO, looking at https://reviews.llvm.org/rG6b3956e123db ?

  • IPO, not LTO. I think I need my eyes checked, thanks for the review!
peterwaller-arm marked an inline comment as done.Jul 5 2022, 1:33 AM
peterwaller-arm added inline comments.
llvm/utils/gn/secondary/llvm/tools/llvm-reduce/BUILD.gn
6

Fixed.

thakis accepted this revision.Jul 5 2022, 1:43 AM

Thanks!

This revision is now accepted and ready to land.Jul 5 2022, 1:43 AM
This revision was landed with ongoing or failed builds.Jul 5 2022, 2:15 AM
This revision was automatically updated to reflect the committed changes.
peterwaller-arm marked an inline comment as done.