This is an archive of the discontinued LLVM Phabricator instance.

Differential D129049

[clang] Fix gcc-6 compilation error. (NFC)
ClosedPublic

Authored by sunho on Jul 3 2022, 12:30 PM.

Details

Reviewers
None
Commits
rG134363208b92: [clang] Fix gcc-6 compilation error. (NFC)
Summary

Fix https://github.com/llvm/llvm-project/issues/55626.

Diff Detail

Unit TestsFailed

TimeTest
1,440 msx64 debian > SanitizerCommon-tsan-x86_64-Linux.Linux::decorate_proc_maps.cpp

Event Timeline

sunho created this revision.Jul 3 2022, 12:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2022, 12:30 PM
sunho requested review of this revision.Jul 3 2022, 12:30 PM
sunho updated this revision to Diff 441977.Jul 3 2022, 12:39 PM
Harbormaster completed remote builds in B173471: Diff 441977.Jul 3 2022, 1:26 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 3 2022, 1:34 PM
This revision was landed with ongoing or failed builds.
Closed by commit rG134363208b92: [clang] Fix gcc-6 compilation error. (NFC) (authored by sunho). · Explain Why
This revision was automatically updated to reflect the committed changes.
sunho added a commit: rG134363208b92: [clang] Fix gcc-6 compilation error. (NFC).
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2022, 1:34 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
sylvestre.ledru added a subscriber: sylvestre.ledru.Jul 3 2022, 2:00 PM

thanks
I will retrigger the CI

Revision Contents

PathSize
clang/
lib/
AST/
Interp/
2 lines

Diff 441977

clang/lib/AST/Interp/ByteCodeExprGen.cpp

Show First 20 Lines • Show All 490 Lines • ▼ Show 20 Lines if (!VD->hasLocalStorage()) {
Program::DeclScope Scope(P, VD); Program::DeclScope Scope(P, VD);
return P.getOrCreateGlobal(VD); return P.getOrCreateGlobal(VD);
} }
return {}; return {};
} }
template <class Emitter> template <class Emitter>
const RecordType *ByteCodeExprGen<Emitter>::getRecordTy(QualType Ty) { const RecordType *ByteCodeExprGen<Emitter>::getRecordTy(QualType Ty) {
if (auto *PT = dyn_cast<PointerType>(Ty)) if (const PointerType *PT = dyn_cast<PointerType>(Ty))
return PT->getPointeeType()->getAs<RecordType>(); return PT->getPointeeType()->getAs<RecordType>();
else else
return Ty->getAs<RecordType>(); return Ty->getAs<RecordType>();
} }
template <class Emitter> template <class Emitter>
Record *ByteCodeExprGen<Emitter>::getRecord(QualType Ty) { Record *ByteCodeExprGen<Emitter>::getRecord(QualType Ty) {
if (auto *RecordTy = getRecordTy(Ty)) { if (auto *RecordTy = getRecordTy(Ty)) {
▲ Show 20 Lines • Show All 73 Lines • Show Last 20 Lines