This is an archive of the discontinued LLVM Phabricator instance.

[libc++] default-construct moved-from test-iterators
ClosedPublic

Authored by philnik on Jul 3 2022, 6:46 AM.

Details

Summary

This way we ensure that we don't use-after-move the iterators.

Diff Detail

Event Timeline

philnik created this revision.Jul 3 2022, 6:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2022, 6:46 AM
philnik requested review of this revision.Jul 3 2022, 6:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2022, 6:46 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Thanks for the cleanup! I want to have another look after the CI is green.

philnik updated this revision to Diff 442048.Jul 4 2022, 2:56 AM
  • Fix CI
philnik updated this revision to Diff 442142.Jul 4 2022, 1:44 PM
  • Try to fix CI
Mordante accepted this revision.Jul 5 2022, 9:12 AM

LGTM. Please update the title, since it's no longer set to nullptr.

This revision is now accepted and ready to land.Jul 5 2022, 9:12 AM
philnik retitled this revision from [libc++] Set moved-from test-iterators to nullptr to [libc++] default-construct moved-from test-iterators .Jul 6 2022, 4:34 AM
This revision was automatically updated to reflect the committed changes.