This is an archive of the discontinued LLVM Phabricator instance.

Reland "[NFC] Add a missing test for for clang-repl"
ClosedPublic

Authored by junaire on Jul 3 2022, 3:09 AM.

Details

Summary

This reverts 3668d1264e2d246f7e222338b8a5cab18ce1bdab
As far as we know, __attribute__((weak)) support has been really bad
in runtimeldyld, so we just disable it in Windows at this moment. This
should fix the angry Windows buildbot.

Diff Detail

Event Timeline

junaire created this revision.Jul 3 2022, 3:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2022, 3:09 AM
junaire requested review of this revision.Jul 3 2022, 3:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2022, 3:09 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
v.g.vassilev accepted this revision.Jul 3 2022, 3:14 AM

Let's move forward and we can remove the XFAIL once https://reviews.llvm.org/D128968 lands.

This revision is now accepted and ready to land.Jul 3 2022, 3:14 AM
This revision was automatically updated to reflect the committed changes.