This is an archive of the discontinued LLVM Phabricator instance.

Differential D129041

Use add_llvm_install_targets for install-llvmlibc
ClosedPublic

Authored by jeffbailey on Jul 2 2022, 8:45 PM.

Details

Reviewers
sivachandra
lntue
Commits
rGbc70ba814dc1: Use add_llvm_install_targets for install-llvmlibc
Summary

Using the LLVM rules for install ensures that DESTDIR and other expected
variables for an LLVM install work correctly.

Tested:
Manually with DESTDIR=/tmp/testinstall/ ninja install-llvmlibc

Diff Detail

Event Timeline

jeffbailey created this revision.Jul 2 2022, 8:45 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 2 2022, 8:45 PM
Herald added subscribers: libc-commits, mgorny. · View Herald Transcript
jeffbailey requested review of this revision.Jul 2 2022, 8:45 PM
jeffbailey added a reviewer: sivachandra.Jul 2 2022, 8:46 PM
Harbormaster completed remote builds in B173426: Diff 441922.Jul 2 2022, 8:50 PM
lntue accepted this revision.Jul 3 2022, 8:48 PM
lntue added a reviewer: lntue.
This revision is now accepted and ready to land.Jul 3 2022, 8:48 PM
Closed by commit rGbc70ba814dc1: Use add_llvm_install_targets for install-llvmlibc (authored by jeffbailey). · Explain WhyJul 4 2022, 10:18 AM
This revision was automatically updated to reflect the committed changes.
jeffbailey added a commit: rGbc70ba814dc1: Use add_llvm_install_targets for install-llvmlibc.

Revision Contents

PathSize
libc/
lib/
9 lines

Diff 442120

libc/lib/CMakeLists.txt

Show All 10 Lines
endif() endif()
install( install(
TARGETS llvmlibc TARGETS llvmlibc
ARCHIVE DESTINATION "${LIBC_INSTALL_LIBRARY_DIR}" ARCHIVE DESTINATION "${LIBC_INSTALL_LIBRARY_DIR}"
COMPONENT llvmlibc COMPONENT llvmlibc
) )
add_custom_target( add_llvm_install_targets(
install-llvmlibc install-llvmlibc
DEPENDS llvmlibc DEPENDS llvmlibc
COMMAND "${CMAKE_COMMAND}" -DCMAKE_INSTALL_COMPONENT=llvmlibc COMPONENT llvmlibc
-P "${LIBC_BINARY_DIR}/cmake_install.cmake"
) )