This change generalizes symlink generation and makes symlinks to tools obey LLVM_TOOLCHAIN_TOOLS. It makes it so that if you exclude llvm-ar from LLVM_TOOLCHAIN_TOOLS you don't end up with broken symlinks to llvm-lib and llvm-ranlib in your install.
Details
Diff Detail
Event Timeline
Chris, do you think add_llvm_tool_symlink may be applicable just to llvm-ar?
I think also clang's cmakefiles may be cleaned up.
llvm/trunk/cmake/modules/AddLLVM.cmake | ||
---|---|---|
1026 ↗ | (On Diff #34755) | I suggest we may reconsider the term "target" around here.
"dest" may be appropriate, IMO. |
1038 ↗ | (On Diff #34755) | I suggest lower indentation with two spaces, like; add_custom_command(OUTPUT ${output_path} COMMAND ${CMAKE_COMMAND} -E ${LLVM_LINK_OR_COPY} "${target_binary}" "${output_path}" Also emacs' cmake-mode suggests so. |
1044 ↗ | (On Diff #34755) | typo. |
I agree. I started looking at that this afternoon. I should have patches tomorrow.
-Chris
Chapuni,
I've addressed all your feedback except the indentation in r247658. I'm not really sure we should be standardizing CMake formatting on the emacs plugin. I don't want to start a religious war, but I don't think we can assume emacs as a standard.
-Chris