This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Use __is_exactly_{input, forward}_iterator
ClosedPublic

Authored by philnik on Jun 27 2022, 7:12 AM.

Details

Diff Detail

Event Timeline

philnik created this revision.Jun 27 2022, 7:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2022, 7:12 AM
philnik requested review of this revision.Jun 27 2022, 7:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2022, 7:12 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jun 30 2022, 5:46 AM

LGTM w/ comments.

libcxx/include/deque
1363

Previously, this would accept input iterators, forward iterators, and bidirectional iterators. After the change, it would only accept input iterators.

If no test fails after making this change, we need to add a test case.

1768

Same comment as above.

This revision is now accepted and ready to land.Jun 30 2022, 5:46 AM
philnik updated this revision to Diff 442036.Jul 4 2022, 2:32 AM
philnik marked 2 inline comments as done.
  • Address comments
philnik updated this revision to Diff 442114.Jul 4 2022, 9:17 AM
  • Fix CI
philnik updated this revision to Diff 442143.Jul 4 2022, 1:46 PM
  • Try to fix CI
This revision was automatically updated to reflect the committed changes.