This is an archive of the discontinued LLVM Phabricator instance.

Differential D12858

[Static Analyzer] Turn on some nullability checks by default.
ClosedPublic

Authored by xazax.hun on Sep 14 2015, 12:06 PM.

Details

Reviewers
dcoughlin
zaks.anna
jordan_rose
Commits
rGe30859959f26: [Static Analyzer] Turn on some nullability checks by default.
rC247614: [Static Analyzer] Turn on some nullability checks by default.
rL247614: [Static Analyzer] Turn on some nullability checks by default.
Summary

This patch turns on some of the nullability related patches by default. These checks has low false positive rate.

Diff Detail

Event Timeline

xazax.hun updated this revision to Diff 34720.Sep 14 2015, 12:06 PM
xazax.hun retitled this revision from to [Static Analyzer] Turn on some nullability checks by default..
xazax.hun updated this object.
xazax.hun added reviewers: zaks.anna, dcoughlin, jordan_rose.
xazax.hun added a subscriber: cfe-commits.
zaks.anna accepted this revision.Sep 14 2015, 12:49 PM
zaks.anna edited edge metadata.
This revision is now accepted and ready to land.Sep 14 2015, 12:49 PM
Closed by commit rL247614: [Static Analyzer] Turn on some nullability checks by default. (authored by xazax). · Explain WhySep 14 2015, 1:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Driver/
5 lines

Diff 34720

lib/Driver/Tools.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 3,316 Lines • ▼ Show 20 Lines if (!Args.hasArg(options::OPT__analyzer_no_default_checks)) {
// Enable the following experimental checkers for testing. // Enable the following experimental checkers for testing.
CmdArgs.push_back( CmdArgs.push_back(
"-analyzer-checker=security.insecureAPI.UncheckedReturn"); "-analyzer-checker=security.insecureAPI.UncheckedReturn");
CmdArgs.push_back("-analyzer-checker=security.insecureAPI.getpw"); CmdArgs.push_back("-analyzer-checker=security.insecureAPI.getpw");
CmdArgs.push_back("-analyzer-checker=security.insecureAPI.gets"); CmdArgs.push_back("-analyzer-checker=security.insecureAPI.gets");
CmdArgs.push_back("-analyzer-checker=security.insecureAPI.mktemp"); CmdArgs.push_back("-analyzer-checker=security.insecureAPI.mktemp");
CmdArgs.push_back("-analyzer-checker=security.insecureAPI.mkstemp"); CmdArgs.push_back("-analyzer-checker=security.insecureAPI.mkstemp");
CmdArgs.push_back("-analyzer-checker=security.insecureAPI.vfork"); CmdArgs.push_back("-analyzer-checker=security.insecureAPI.vfork");
// Default nullability checks.
CmdArgs.push_back("-analyzer-checker=nullability.NullPassedToNonnull");
CmdArgs.push_back(
"-analyzer-checker=nullability.NullReturnedFromNonnull");
} }
// Set the output format. The default is plist, for (lame) historical // Set the output format. The default is plist, for (lame) historical
// reasons. // reasons.
CmdArgs.push_back("-analyzer-output"); CmdArgs.push_back("-analyzer-output");
if (Arg *A = Args.getLastArg(options::OPT__analyzer_output)) if (Arg *A = Args.getLastArg(options::OPT__analyzer_output))
CmdArgs.push_back(A->getValue()); CmdArgs.push_back(A->getValue());
else else
▲ Show 20 Lines • Show All 6,405 Lines • Show Last 20 Lines