This is an archive of the discontinued LLVM Phabricator instance.

Differential D128511

[clang-tidy] Make the cert/uppercase-literal-suffix-integer fully hermetic.
ClosedPublic

Authored by hokein on Jun 24 2022, 2:42 AM.

Details

Reviewers
LegalizeAdulthood
aaron.ballman
Commits
rG9081d3d8097a: [clang-tidy] Make the cert/uppercase-literal-suffix-integer fully hermetic.
Summary

after the test-reorg commit (89a1d03e2b379e325daa5249411e414bbd995b5e), the
cert/uppercase test starts to fail in our internal environment -- it accesses
a header file from "../readability", which is not a friendly to a hermetic test environment.

This change makes the test full hermetic, and does some cleanup on the
uppercase header (I think it is better to move it the share
Inputs/Header directory, and rename it)

Diff Detail

Event Timeline

hokein created this revision.Jun 24 2022, 2:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2022, 2:42 AM
Herald added a subscriber: xazax.hun. · View Herald Transcript
hokein requested review of this revision.Jun 24 2022, 2:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2022, 2:42 AM
Harbormaster completed remote builds in B171811: Diff 439680.Jun 24 2022, 2:58 AM
aaron.ballman accepted this revision.Jun 24 2022, 4:50 AM

LGTM!

This revision is now accepted and ready to land.Jun 24 2022, 4:50 AM
Closed by commit rG9081d3d8097a: [clang-tidy] Make the cert/uppercase-literal-suffix-integer fully hermetic. (authored by hokein). · Explain WhyJun 24 2022, 5:18 AM
This revision was automatically updated to reflect the committed changes.
hokein added a commit: rG9081d3d8097a: [clang-tidy] Make the cert/uppercase-literal-suffix-integer fully hermetic..
LegalizeAdulthood added inline comments.Jul 1 2022, 1:40 PM
clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/integral_constant.h
1

Identifiers beginning with _ followed by an uppercase letter are reserved for the implementation.

Include guards should never include double underscores or begin with an underscore.

Revision Contents

Diff 439707

clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/integral_constant.h

  • This file was moved from clang-tools-extra/test/clang-tidy/checkers/readability/uppercase-literal-suffix.h.
#ifndef _INTEGRAL_CONSTANT_H_
LegalizeAdulthoodUnsubmitted
Not Done
ReplyInline Actions

Identifiers beginning with _ followed by an uppercase letter are reserved for the implementation.

Include guards should never include double underscores or begin with an underscore.

LegalizeAdulthood: Identifiers beginning with `_` followed by an uppercase letter are [[ https://en.cppreference.
#define _INTEGRAL_CONSTANT_H_
template <class T, T v> template <class T, T v>
struct integral_constant { struct integral_constant {
static constexpr T value = v; static constexpr T value = v;
typedef T value_type; typedef T value_type;
typedef integral_constant type; // using injected-class-name typedef integral_constant type; // using injected-class-name
constexpr operator value_type() const noexcept { return value; } constexpr operator value_type() const noexcept { return value; }
}; };
using false_type = integral_constant<bool, false>; using false_type = integral_constant<bool, false>;
using true_type = integral_constant<bool, true>; using true_type = integral_constant<bool, true>;
template <class T, class U> template <class T, class U>
struct is_same : false_type {}; struct is_same : false_type {};
template <class T> template <class T>
struct is_same<T, T> : true_type {}; struct is_same<T, T> : true_type {};
#endif

clang-tools-extra/test/clang-tidy/checkers/cert/uppercase-literal-suffix-integer.cpp

// RUN: %check_clang_tidy %s cert-dcl16-c %t -- -- -I %S // RUN: %check_clang_tidy %s cert-dcl16-c %t -- -- -I %clang_tidy_headers
// RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp // RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp
// RUN: clang-tidy %t.cpp -checks='-*,cert-dcl16-c' -fix -- -I %S // RUN: clang-tidy %t.cpp -checks='-*,cert-dcl16-c' -fix -- -I %clang_tidy_headers
// RUN: clang-tidy %t.cpp -checks='-*,cert-dcl16-c' -warnings-as-errors='-*,cert-dcl16-c' -- -I %S // RUN: clang-tidy %t.cpp -checks='-*,cert-dcl16-c' -warnings-as-errors='-*,cert-dcl16-c' -- -I %clang_tidy_headers
#include "../readability/uppercase-literal-suffix.h" #include "integral_constant.h"
void integer_suffix() { void integer_suffix() {
static constexpr auto v0 = __LINE__; // synthetic static constexpr auto v0 = __LINE__; // synthetic
static_assert(v0 == 9 || v0 == 5, ""); static_assert(v0 == 9 || v0 == 5, "");
static constexpr auto v1 = __cplusplus; // synthetic, long static constexpr auto v1 = __cplusplus; // synthetic, long
static constexpr auto v2 = 1; // no literal static constexpr auto v2 = 1; // no literal
▲ Show 20 Lines • Show All 145 Lines • Show Last 20 Lines

clang-tools-extra/test/clang-tidy/checkers/readability/uppercase-literal-suffix-float16.cpp

// RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -- -target aarch64-linux-gnu -I %S // RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -- -target aarch64-linux-gnu -I %clang_tidy_headers
#include "uppercase-literal-suffix.h" #include "integral_constant.h"
void float16_normal_literals() { void float16_normal_literals() {
// _Float16 // _Float16
static constexpr auto v14 = 1.f16; static constexpr auto v14 = 1.f16;
// CHECK-MESSAGES: :[[@LINE-1]]:31: warning: floating point literal has suffix 'f16', which is not uppercase // CHECK-MESSAGES: :[[@LINE-1]]:31: warning: floating point literal has suffix 'f16', which is not uppercase
// CHECK-MESSAGES-NEXT: static constexpr auto v14 = 1.f16; // CHECK-MESSAGES-NEXT: static constexpr auto v14 = 1.f16;
// CHECK-MESSAGES-NEXT: ^ ~ // CHECK-MESSAGES-NEXT: ^ ~
Show All 40 Lines

clang-tools-extra/test/clang-tidy/checkers/readability/uppercase-literal-suffix-floating-point.cpp

// RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -- -target x86_64-pc-linux-gnu -I %S // RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -- -target x86_64-pc-linux-gnu -I %clang_tidy_headers
// RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp // RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp
// RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -fix -- -target x86_64-pc-linux-gnu -I %S // RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -fix -- -target x86_64-pc-linux-gnu -I %clang_tidy_headers
// RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -warnings-as-errors='-*,readability-uppercase-literal-suffix' -- -target x86_64-pc-linux-gnu -I %S // RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -warnings-as-errors='-*,readability-uppercase-literal-suffix' -- -target x86_64-pc-linux-gnu -I %clang_tidy_headers
#include "uppercase-literal-suffix.h" #include "integral_constant.h"
void floating_point_suffix() { void floating_point_suffix() {
static constexpr auto v0 = 1.; // no literal static constexpr auto v0 = 1.; // no literal
static_assert(is_same<decltype(v0), const double>::value, ""); static_assert(is_same<decltype(v0), const double>::value, "");
static_assert(v0 == 1., ""); static_assert(v0 == 1., "");
static constexpr auto v1 = 1.e0; // no literal static constexpr auto v1 = 1.e0; // no literal
static_assert(is_same<decltype(v1), const double>::value, ""); static_assert(is_same<decltype(v1), const double>::value, "");
▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines

clang-tools-extra/test/clang-tidy/checkers/readability/uppercase-literal-suffix-hexadecimal-floating-point.cpp

// RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -- -target x86_64-pc-linux-gnu -I %S // RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -- -target x86_64-pc-linux-gnu -I %clang_tidy_headers
// RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp // RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp
// RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -fix -- -target x86_64-pc-linux-gnu -I %S // RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -fix -- -target x86_64-pc-linux-gnu -I %clang_tidy_headers
// RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -warnings-as-errors='-*,readability-uppercase-literal-suffix' -- -target x86_64-pc-linux-gnu -I %S // RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -warnings-as-errors='-*,readability-uppercase-literal-suffix' -- -target x86_64-pc-linux-gnu -I %clang_tidy_headers
#include "uppercase-literal-suffix.h" #include "integral_constant.h"
void floating_point_suffix() { void floating_point_suffix() {
static constexpr auto v0 = 0x0p0; // no literal static constexpr auto v0 = 0x0p0; // no literal
static_assert(is_same<decltype(v0), const double>::value, ""); static_assert(is_same<decltype(v0), const double>::value, "");
static_assert(v0 == 0, ""); static_assert(v0 == 0, "");
// Float // Float
▲ Show 20 Lines • Show All 126 Lines • Show Last 20 Lines

clang-tools-extra/test/clang-tidy/checkers/readability/uppercase-literal-suffix-integer-custom-list.cpp

// RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -config="{CheckOptions: [{key: readability-uppercase-literal-suffix.NewSuffixes, value: 'L;uL'}]}" -- -I %S // RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -config="{CheckOptions: [{key: readability-uppercase-literal-suffix.NewSuffixes, value: 'L;uL'}]}" -- -I %clang_tidy_headers
// RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp // RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp
// RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -fix -config="{CheckOptions: [{key: readability-uppercase-literal-suffix.NewSuffixes, value: 'L;uL'}]}" -- -I %S // RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -fix -config="{CheckOptions: [{key: readability-uppercase-literal-suffix.NewSuffixes, value: 'L;uL'}]}" -- -I %clang_tidy_headers
// RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -warnings-as-errors='-*,readability-uppercase-literal-suffix' -config="{CheckOptions: [{key: readability-uppercase-literal-suffix.NewSuffixes, value: 'L;uL'}]}" -- -I %S // RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -warnings-as-errors='-*,readability-uppercase-literal-suffix' -config="{CheckOptions: [{key: readability-uppercase-literal-suffix.NewSuffixes, value: 'L;uL'}]}" -- -I %clang_tidy_headers
#include "uppercase-literal-suffix.h" #include "integral_constant.h"
void integer_suffix() { void integer_suffix() {
// Unsigned // Unsigned
static constexpr auto v3 = 1u; // OK. static constexpr auto v3 = 1u; // OK.
static_assert(is_same<decltype(v3), const unsigned int>::value, ""); static_assert(is_same<decltype(v3), const unsigned int>::value, "");
static_assert(v3 == 1, ""); static_assert(v3 == 1, "");
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines

clang-tools-extra/test/clang-tidy/checkers/readability/uppercase-literal-suffix-integer-ms.cpp

// RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -- -target x86_64-pc-linux-gnu -I %S -fms-extensions // RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -- -target x86_64-pc-linux-gnu -I %clang_tidy_headers -fms-extensions
// RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp // RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp
// RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -fix -- -target x86_64-pc-linux-gnu -I %S -fms-extensions // RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -fix -- -target x86_64-pc-linux-gnu -I %clang_tidy_headers -fms-extensions
// RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -warnings-as-errors='-*,readability-uppercase-literal-suffix' -- -target x86_64-pc-linux-gnu -I %S -fms-extensions // RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -warnings-as-errors='-*,readability-uppercase-literal-suffix' -- -target x86_64-pc-linux-gnu -I %clang_tidy_headers -fms-extensions
#include "uppercase-literal-suffix.h" #include "integral_constant.h"
void integer_suffix() { void integer_suffix() {
static constexpr auto v0 = __LINE__; // synthetic static constexpr auto v0 = __LINE__; // synthetic
static_assert(v0 == 9 || v0 == 5, ""); static_assert(v0 == 9 || v0 == 5, "");
static constexpr auto v1 = __cplusplus; // synthetic, long static constexpr auto v1 = __cplusplus; // synthetic, long
static constexpr auto v2 = 1; // no literal static constexpr auto v2 = 1; // no literal
▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines

clang-tools-extra/test/clang-tidy/checkers/readability/uppercase-literal-suffix-integer.cpp

// RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -- -I %S // RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -- -I %clang_tidy_headers
// RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp // RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp
// RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -fix -- -I %S // RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -fix -- -I %clang_tidy_headers
// RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -warnings-as-errors='-*,readability-uppercase-literal-suffix' -- -I %S // RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' -warnings-as-errors='-*,readability-uppercase-literal-suffix' -- -I %clang_tidy_headers
#include "uppercase-literal-suffix.h" #include "integral_constant.h"
void integer_suffix() { void integer_suffix() {
static constexpr auto v0 = __LINE__; // synthetic static constexpr auto v0 = __LINE__; // synthetic
static_assert(v0 == 9 || v0 == 5, ""); static_assert(v0 == 9 || v0 == 5, "");
static constexpr auto v1 = __cplusplus; // synthetic, long static constexpr auto v1 = __cplusplus; // synthetic, long
static constexpr auto v2 = 1; // no literal static constexpr auto v2 = 1; // no literal
▲ Show 20 Lines • Show All 284 Lines • Show Last 20 Lines

clang-tools-extra/test/clang-tidy/checkers/readability/uppercase-literal-suffix.h

  • This file was moved to clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/integral_constant.h.