Page MenuHomePhabricator

[X86][AMX] Update tests to use opaque pointers
ClosedPublic

Authored by nikic on Thu, Jun 23, 3:41 AM.

Details

Summary

Updating AMX to use opaque pointers, there are some codegen differences, so I want to double check with maintainers that these are fine. I believe these are side-effects of bitcasts not being present (especially at -O0).

Diff Detail

Event Timeline

nikic created this revision.Thu, Jun 23, 3:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Jun 23, 3:41 AM
Herald added subscribers: jsji, pengfei. · View Herald Transcript
nikic requested review of this revision.Thu, Jun 23, 3:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Jun 23, 3:41 AM
LuoYuanke accepted this revision.Thu, Jun 23, 4:22 AM

LGTM, except minor format issue. Thanks, @nikic

llvm/test/CodeGen/X86/AMX/amx-zero-config.ll
9

Need blank character between type and variable name (ptr %buf)?

This revision is now accepted and ready to land.Thu, Jun 23, 4:22 AM
This revision was landed with ongoing or failed builds.Thu, Jun 23, 5:37 AM
This revision was automatically updated to reflect the committed changes.
nikic marked an inline comment as done.