This is an archive of the discontinued LLVM Phabricator instance.

[lld/mac] On Apple systems, call CC_SHA256 from libSystem
ClosedPublic

Authored by thakis on Jun 21 2022, 10:53 AM.

Details

Summary

It's in libSystem, so it doesn't bring in any new deps, and it's
currently much faster than LLVM's current SHA256 implementation.

Makes linking Chromium Framework with ld64.lld 17% faster. See also PR56121.

No behavior change.

Diff Detail

Event Timeline

thakis created this revision.Jun 21 2022, 10:53 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 21 2022, 10:53 AM
thakis requested review of this revision.Jun 21 2022, 10:53 AM
oontvoo accepted this revision.Jun 21 2022, 11:02 AM
oontvoo added a subscriber: oontvoo.

Nice!!

This revision is now accepted and ready to land.Jun 21 2022, 11:02 AM
int3 added a subscriber: int3.Jun 21 2022, 11:31 AM

17%, wow

int3 accepted this revision.Jun 21 2022, 11:36 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2022, 11:58 AM