This implements
- LWG2762 unique_ptr operator*() should be noexcept.
Differential D128214
[libc++] Makes `unique_ptr operator*() noexcept. Mordante on Jun 20 2022, 9:08 AM. Authored by
Details
Diff Detail
Unit Tests Event TimelineComment Actions Thanks for the review! However I will put this on hold. The CI failure seems to indicate there's an issue with the LWG issue. GCC agrees with Clang so I need to do some more investigation.
Comment Actions Rebased and address review comments.
Comment Actions LGTM once the comments have been addressed.
|
This comment seems a bit unnecessary to me once we add tests for void. Then it's pretty self explanatory, if you try to remove this the test would fail.