This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Don't force -O2 when building the benchmarks
ClosedPublic

Authored by ldionne on Jun 16 2022, 10:40 AM.

Details

Summary

The optimization level used when building the benchmarks should
match the optimization level of the current build. Otherwise, we
can end up mixing an -O3 or -O0 optimized dylib with benchmarks
built with -O2, which is really misleading.

Diff Detail

Event Timeline

ldionne created this revision.Jun 16 2022, 10:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2022, 10:40 AM
Herald added a subscriber: mgorny. · View Herald Transcript
ldionne requested review of this revision.Jun 16 2022, 10:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2022, 10:40 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
var-const accepted this revision.Jun 16 2022, 11:13 AM
This revision is now accepted and ready to land.Jun 16 2022, 11:13 AM
Mordante accepted this revision.Jun 17 2022, 9:18 AM
Mordante added a subscriber: Mordante.

LGTM, thanks!

This revision was landed with ongoing or failed builds.Jun 17 2022, 2:34 PM
This revision was automatically updated to reflect the committed changes.