This is an archive of the discontinued LLVM Phabricator instance.

Differential D127984

[libc][obvious] fix sign warning in file_writer
ClosedPublic

Authored by michaelrj on Jun 16 2022, 10:14 AM.

Details

Reviewers
sivachandra
lntue
Commits
rGad709a752daa: [libc][obvious] fix sign warning in file_writer
Summary

In the sign writer, a size_t was being compared to an int. This patch
casts the size_t to an int so that the comparison doesn't cause a sign
comparison warning.

Diff Detail

Event Timeline

michaelrj created this revision.Jun 16 2022, 10:14 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 16 2022, 10:14 AM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
michaelrj requested review of this revision.Jun 16 2022, 10:14 AM
Harbormaster completed remote builds in B170297: Diff 437589.Jun 16 2022, 10:20 AM
lntue accepted this revision.Jun 17 2022, 7:37 AM
This revision is now accepted and ready to land.Jun 17 2022, 7:37 AM
Closed by commit rGad709a752daa: [libc][obvious] fix sign warning in file_writer (authored by michaelrj). · Explain WhyJun 17 2022, 9:48 AM
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rGad709a752daa: [libc][obvious] fix sign warning in file_writer.

Revision Contents

PathSize
libc/
src/
stdio/
printf_core/
2 lines

Diff 437948

libc/src/stdio/printf_core/file_writer.cpp

Show All 9 Lines
#include "src/__support/File/file.h" #include "src/__support/File/file.h"
#include <stddef.h> #include <stddef.h>
namespace __llvm_libc { namespace __llvm_libc {
namespace printf_core { namespace printf_core {
int FileWriter::write(const char *__restrict to_write, size_t len) { int FileWriter::write(const char *__restrict to_write, size_t len) {
int written = file->write_unlocked(to_write, len); int written = file->write_unlocked(to_write, len);
if (written != len) if (written != static_cast<int>(len))
written = -1; written = -1;
if (file->error_unlocked()) if (file->error_unlocked())
written = -2; written = -2;
return written; return written;
} }
int write_to_file(void *raw_pointer, const char *__restrict to_write, int write_to_file(void *raw_pointer, const char *__restrict to_write,
size_t len) { size_t len) {
FileWriter *file_writer = reinterpret_cast<FileWriter *>(raw_pointer); FileWriter *file_writer = reinterpret_cast<FileWriter *>(raw_pointer);
return file_writer->write(to_write, len); return file_writer->write(to_write, len);
} }
} // namespace printf_core } // namespace printf_core
} // namespace __llvm_libc } // namespace __llvm_libc