This is an archive of the discontinued LLVM Phabricator instance.

Differential D127912

Pass through even more LIBCXX_* variables to libfuzzer's custom lib++
ClosedPublic

Authored by ccross on Jun 15 2022, 3:53 PM.

Details

Reviewers
phosek
Commits
rG80aa41d9df3d: Pass through even more LIBCXX_* variables to libfuzzer's custom lib++
Summary

Similar to D120946, pass LIBCXX_HAS_GCC_S_LIB and LIBCXX_USE_COMPILER_RT
through to the custom lib++ builds so that libfuzzer doesn't end up with
a .deplibs section that links against those libraries when the
variables are set to false.

Diff Detail

Unit TestsFailed

TimeTest
1,390 msx64 debian > Clang.utils/update_cc_test_checks::check-globals.test
590 msx64 debian > Clang.utils/update_cc_test_checks::global-hex-value-regex.test
590 msx64 debian > Clang.utils/update_cc_test_checks::global-value-regex.test
630 msx64 debian > SanitizerCommon-asan-x86_64-Linux.Linux::decorate_proc_maps.cpp
580 msx64 debian > SanitizerCommon-lsan-x86_64-Linux.Linux::decorate_proc_maps.cpp
View Full Test Results (48 Failed)

Event Timeline

ccross created this revision.Jun 15 2022, 3:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2022, 3:53 PM
Herald added subscribers: Enna1, mgorny. · View Herald Transcript
ccross requested review of this revision.Jun 15 2022, 3:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2022, 3:53 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
ccross added a reviewer: phosek.Jun 15 2022, 3:54 PM
phosek accepted this revision.Jun 15 2022, 3:57 PM

LGTM

This revision is now accepted and ready to land.Jun 15 2022, 3:57 PM
Harbormaster completed remote builds in B170142: Diff 437384.Jun 15 2022, 4:18 PM
This revision was landed with ongoing or failed builds.Jun 15 2022, 7:07 PM
Closed by commit rG80aa41d9df3d: Pass through even more LIBCXX_* variables to libfuzzer's custom lib++ (authored by ccross, committed by pirama). · Explain Why
This revision was automatically updated to reflect the committed changes.
pirama added a commit: rG80aa41d9df3d: Pass through even more LIBCXX_* variables to libfuzzer's custom lib++.

Revision Contents

PathSize
compiler-rt/
cmake/
Modules/
2 lines

Diff 437384

compiler-rt/cmake/Modules/AddCompilerRT.cmake

Show First 20 Lines • Show All 640 Lines • ▼ Show 20 Lines set(PASSTHROUGH_VARIABLES
CMAKE_RANLIB CMAKE_RANLIB
CMAKE_NM CMAKE_NM
CMAKE_OBJCOPY CMAKE_OBJCOPY
CMAKE_OBJDUMP CMAKE_OBJDUMP
CMAKE_STRIP CMAKE_STRIP
CMAKE_READELF CMAKE_READELF
CMAKE_SYSROOT CMAKE_SYSROOT
LIBCXX_HAS_MUSL_LIBC LIBCXX_HAS_MUSL_LIBC
LIBCXX_HAS_GCC_S_LIB
LIBCXX_HAS_PTHREAD_LIB LIBCXX_HAS_PTHREAD_LIB
LIBCXX_HAS_RT_LIB LIBCXX_HAS_RT_LIB
LIBCXX_USE_COMPILER_RT
LIBCXXABI_HAS_PTHREAD_LIB LIBCXXABI_HAS_PTHREAD_LIB
PYTHON_EXECUTABLE PYTHON_EXECUTABLE
Python3_EXECUTABLE Python3_EXECUTABLE
Python2_EXECUTABLE Python2_EXECUTABLE
CMAKE_SYSTEM_NAME) CMAKE_SYSTEM_NAME)
foreach(variable ${PASSTHROUGH_VARIABLES}) foreach(variable ${PASSTHROUGH_VARIABLES})
get_property(is_value_set CACHE ${variable} PROPERTY VALUE SET) get_property(is_value_set CACHE ${variable} PROPERTY VALUE SET)
if(${is_value_set}) if(${is_value_set})
▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines