This is an archive of the discontinued LLVM Phabricator instance.

Differential D127808

[memprof] Update the test comments to include -Wl,-no-pie
ClosedPublic

Authored by snehasish on Jun 14 2022, 4:32 PM.

Details

Reviewers
tejohnson
Commits
rGb0c51f00ae68: [memprof] Update the test comments to include -Wl,-no-pie
Summary

Until we have symbolization for position independent code lets update
this documentation since clang now defaults to position independent
code.

Diff Detail

Event Timeline

snehasish created this revision.Jun 14 2022, 4:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2022, 4:32 PM
snehasish requested review of this revision.Jun 14 2022, 4:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2022, 4:32 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
tejohnson added inline comments.Jun 14 2022, 4:35 PM
llvm/test/tools/llvm-profdata/memprof-basic.test
29–30

Do we also need -fno-pie here and elsewhere?

32

BTW I noticed that the binary name here and in a couple other files is wrong.

snehasish updated this revision to Diff 436978.Jun 14 2022, 5:01 PM

Update binary names to be consistent.

snehasish marked an inline comment as done.Jun 14 2022, 5:04 PM

PTAL, thanks!

llvm/test/tools/llvm-profdata/memprof-basic.test
29–30

No, I checked for this test case (and the others in this patch) -Wl,-no-pie is sufficient.

Harbormaster completed remote builds in B169871: Diff 436978.Jun 14 2022, 6:02 PM
tejohnson accepted this revision.Jun 14 2022, 7:16 PM

lgtm

This revision is now accepted and ready to land.Jun 14 2022, 7:16 PM
This revision was landed with ongoing or failed builds.Jun 15 2022, 9:49 AM
Closed by commit rGb0c51f00ae68: [memprof] Update the test comments to include -Wl,-no-pie (authored by snehasish). · Explain Why
This revision was automatically updated to reflect the committed changes.
snehasish added a commit: rGb0c51f00ae68: [memprof] Update the test comments to include -Wl,-no-pie.
MaskRay mentioned this in rG103b28902fd6: [llvm-profdata][test] Change -Wl,-no-pie to -no-pie after D127808.Jun 15 2022, 10:46 AM

Revision Contents

PathSize
llvm/
test/
tools/
llvm-profdata/
5 lines
5 lines
5 lines
5 lines

Diff 437223

llvm/test/tools/llvm-profdata/memprof-basic.test

Show All 20 Lines
virtual addresses for the callstack, we do not expect the raw binary profile to virtual addresses for the callstack, we do not expect the raw binary profile to
be deterministic. The summary should be deterministic apart from changes to be deterministic. The summary should be deterministic apart from changes to
the shared libraries linked in which could change the number of segments the shared libraries linked in which could change the number of segments
recorded. recorded.
``` ```
clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \ clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \
-fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \ -fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \
-fno-optimize-sibling-calls -m64 -Wl,-build-id source.c -o basic.memprofexe -fno-optimize-sibling-calls -m64 -Wl,-build-id -Wl,-no-pie \
source.c -o basic.memprofexe
tejohnsonUnsubmitted
Not Done
ReplyInline Actions

Do we also need -fno-pie here and elsewhere?

tejohnson: Do we also need -fno-pie here and elsewhere?
snehasishAuthorUnsubmitted
Done
ReplyInline Actions

No, I checked for this test case (and the others in this patch) -Wl,-no-pie is sufficient.

snehasish: No, I checked for this test case (and the others in this patch) -Wl,-no-pie is sufficient.
env MEMPROF_OPTIONS=log_path=stdout ./rawprofile.out > basic.memprofraw env MEMPROF_OPTIONS=log_path=stdout ./basic.memprofexe > basic.memprofraw
tejohnsonUnsubmitted
Done
ReplyInline Actions

BTW I noticed that the binary name here and in a couple other files is wrong.

tejohnson: BTW I noticed that the binary name here and in a couple other files is wrong.
``` ```
RUN: llvm-profdata show --memory %p/Inputs/basic.memprofraw --profiled-binary %p/Inputs/basic.memprofexe -o - | FileCheck %s RUN: llvm-profdata show --memory %p/Inputs/basic.memprofraw --profiled-binary %p/Inputs/basic.memprofexe -o - | FileCheck %s
We expect 2 MIB entries, 1 each for the malloc calls in the program. Any We expect 2 MIB entries, 1 each for the malloc calls in the program. Any
additional allocations which do not originate from the main binary are pruned. additional allocations which do not originate from the main binary are pruned.
CHECK: MemprofProfile: CHECK: MemprofProfile:
▲ Show 20 Lines • Show All 112 Lines • Show Last 20 Lines

llvm/test/tools/llvm-profdata/memprof-inline.test

Show All 24 Lines
} }
``` ```
Compile and run with the following commands: Compile and run with the following commands:
``` ```
bin/clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \ bin/clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \
-fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \ -fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \
-fno-optimize-sibling-calls -m64 -Wl,-build-id inline.c -o memprof-inline.exe -fno-optimize-sibling-calls -m64 -Wl,-build-id -Wl,-no-pie \
inline.c -o inline.memprofexe
env MEMPROF_OPTIONS=log_path=stdout ./memprof-inline.exe > inline.memprofraw env MEMPROF_OPTIONS=log_path=stdout ./inline.memprofexe > inline.memprofraw
``` ```
RUN: llvm-profdata show --memory %p/Inputs/inline.memprofraw --profiled-binary %p/Inputs/inline.memprofexe | FileCheck %s RUN: llvm-profdata show --memory %p/Inputs/inline.memprofraw --profiled-binary %p/Inputs/inline.memprofexe | FileCheck %s
CHECK: MemprofProfile: CHECK: MemprofProfile:
CHECK-NEXT: Summary: CHECK-NEXT: Summary:
CHECK-NEXT: Version: 1 CHECK-NEXT: Version: 1
CHECK-NEXT: NumSegments: 9 CHECK-NEXT: NumSegments: 9
▲ Show 20 Lines • Show All 183 Lines • Show Last 20 Lines

llvm/test/tools/llvm-profdata/memprof-merge.test

Show All 22 Lines
# do not have zlib. # do not have zlib.
clang -mllvm -enable-name-compression=false -fprofile-generate source.c -o instr.out clang -mllvm -enable-name-compression=false -fprofile-generate source.c -o instr.out
./instr.out ./instr.out
mv *.profraw basic.profraw mv *.profraw basic.profraw
# Collect memprof profile. # Collect memprof profile.
clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \ clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \
-fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \ -fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \
-fno-optimize-sibling-calls -m64 -Wl,-build-id source.c -o basic.memprofexe -fno-optimize-sibling-calls -m64 -Wl,-build-id -Wl,-no-pie \
source.c -o basic.memprofexe
env MEMPROF_OPTIONS=log_path=stdout ./rawprofile.out > basic.memprofraw env MEMPROF_OPTIONS=log_path=stdout ./basic.memprofexe > basic.memprofraw
``` ```
RUN: llvm-profdata merge %p/Inputs/basic.profraw %p/Inputs/basic.memprofraw --profiled-binary %p/Inputs/basic.memprofexe -o %t.prof RUN: llvm-profdata merge %p/Inputs/basic.profraw %p/Inputs/basic.memprofraw --profiled-binary %p/Inputs/basic.memprofexe -o %t.prof
RUN: llvm-profdata show %t.prof | FileCheck %s RUN: llvm-profdata show %t.prof | FileCheck %s
For now we only check the validity of the instrumented profile since we don't For now we only check the validity of the instrumented profile since we don't
have a way to display the contents of the memprof indexed format yet. have a way to display the contents of the memprof indexed format yet.
CHECK: Instrumentation level: IR entry_first = 0 CHECK: Instrumentation level: IR entry_first = 0
CHECK: Total functions: 1 CHECK: Total functions: 1
CHECK: Maximum function count: 1 CHECK: Maximum function count: 1
CHECK: Maximum internal block count: 0 CHECK: Maximum internal block count: 0

llvm/test/tools/llvm-profdata/memprof-multi.test

Show All 22 Lines
virtual addresses for the callstack, we do not expect the raw binary profile to virtual addresses for the callstack, we do not expect the raw binary profile to
be deterministic. The summary should be deterministic apart from changes to be deterministic. The summary should be deterministic apart from changes to
the shared libraries linked in which could change the number of segments the shared libraries linked in which could change the number of segments
recorded. recorded.
``` ```
clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \ clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \
-fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \ -fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \
-fno-optimize-sibling-calls -m64 -Wl,-build-id source.c -o multi.memprofexe -fno-optimize-sibling-calls -m64 -Wl,-build-id -Wl,-no-pie \
source.c -o multi.memprofexe
env MEMPROF_OPTIONS=log_path=stdout ./rawprofile.out > multi.memprofraw env MEMPROF_OPTIONS=log_path=stdout ./multi.memprofexe > multi.memprofraw
``` ```
RUN: llvm-profdata show --memory %p/Inputs/multi.memprofraw --profiled-binary %p/Inputs/multi.memprofexe -o - | FileCheck %s RUN: llvm-profdata show --memory %p/Inputs/multi.memprofraw --profiled-binary %p/Inputs/multi.memprofexe -o - | FileCheck %s
We expect 2 MIB entries, 1 each for the malloc calls in the program. We expect 2 MIB entries, 1 each for the malloc calls in the program.
CHECK: MemprofProfile: CHECK: MemprofProfile:
CHECK-NEXT: Summary: CHECK-NEXT: Summary:
Show All 13 Lines