This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Removes unneeded <iterator> includes.
ClosedPublic

Authored by Mordante on Jun 13 2022, 11:06 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rG4cd04d1687f1: [libc++] Removes unneeded <iterator> includes.

Diff Detail

Event Timeline

Mordante created this revision.Jun 13 2022, 11:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 11:06 AM
Mordante requested review of this revision.Jun 13 2022, 11:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 11:06 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.Jun 13 2022, 11:09 AM
philnik added a subscriber: philnik.

LGTM with passing CI.

This revision is now accepted and ready to land.Jun 13 2022, 11:09 AM
Mordante updated this revision to Diff 436803.Jun 14 2022, 8:42 AM

Adds missing includes.

This revision was automatically updated to reflect the committed changes.
sberg added a subscriber: sberg.Jun 15 2022, 10:35 PM

But now

#include <array>
auto b = std::begin("");

fails to compile, even though [iterator.range]/1 states: "In addition to being available via inclusion of the <iterator> header, the function templates in 23.7 are
available when any of the following headers are included: <array> (22.3.2), [...]"

But now

#include <array>
auto b = std::begin("");

fails to compile, even though [iterator.range]/1 states: "In addition to being available via inclusion of the <iterator> header, the function templates in 23.7 are
available when any of the following headers are included: <array> (22.3.2), [...]"

Thanks for the comment! @philnik created D127953 which addresses this issue.