This is an archive of the discontinued LLVM Phabricator instance.

gn build: Add support for building the AArch64 LSE builtins.
ClosedPublic

Authored by pcc on Jun 10 2022, 10:12 PM.

Diff Detail

Event Timeline

pcc created this revision.Jun 10 2022, 10:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2022, 10:12 PM
pcc requested review of this revision.Jun 10 2022, 10:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2022, 10:12 PM
thakis added inline comments.Jun 12 2022, 10:34 AM
llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn
38

This angers and confuses the sync script as-is:

% llvm/utils/gn/build/sync_source_lists_from_cmake.py 
[gn build] Port a72d462eb9b9 -- https://reviews.llvm.org/rGa72d462eb9b9
  llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn
   remove:
    aarch64/lse.S
pcc updated this revision to Diff 436528.Jun 13 2022, 12:51 PM

Stop sync_source_lists_from_cmake.py from finding the reference to the source file

pcc added inline comments.Jun 13 2022, 12:53 PM
llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn
38

Ah, found a way to silence that.

thakis accepted this revision.Jun 13 2022, 12:53 PM

clever!

This revision is now accepted and ready to land.Jun 13 2022, 12:53 PM
This revision was landed with ongoing or failed builds.Jun 13 2022, 1:16 PM
This revision was automatically updated to reflect the committed changes.